FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner,docs: align documentation with actual stdout/stderr behavior by MoLow · Pull Request #53131 · nodejs/node · GitHub

/ node Public

test_runner,docs: align documentation with actual stdout/stderr behavior - #53131

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-stdout-docs
May 28, 2024
ConversationCommits (1)ChecksFiles changed
Merged

test_runner,docs: align documentation with actual stdout/stderr behavior#53131
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-stdout-docs

Conversation

MoLow commented May 24, 2024

Copy link
Copy Markdown
Member

refs: #53103 (comment)

see tests verifying this behavior:

node/test/parallel/test-runner-v8-deserializer.mjs

Line 50 in c7a63b0

{ data: { __proto__: null, file: 'filetest', message: 'unknown' }, type: 'test:stdout' },

nodejs-github-bot commented May 24, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 24, 2024
MoLow commented May 24, 2024
View reviewed changes
Comment thread lib/internal/test_runner/tests_stream.js Outdated

MoLow May 24, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this was unused. actual events are emitted here (using kEmitMessage directly):

node/lib/internal/test_runner/runner.js

Lines 367 to 371 in c7a63b0

subtest.addToReport({
__proto__: null,
type: 'test:stderr',
data: { __proto__: null, file: path, message: line + '\n' },
});

aduh95 commented May 24, 2024

Copy link
Copy Markdown
Contributor

The subsystem should be doc, not docs

MoLow force-pushed the fix-stdout-docs branch from 3e1d840 to e2f2537 Compare May 25, 2024 21:49
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2024

nodejs-github-bot commented May 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59416/

nodejs-github-bot commented May 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59420/

nodejs-github-bot commented May 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59441/

nodejs-github-bot commented May 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59479/

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2024

nodejs-github-bot commented May 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59484/

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2024
nodejs-github-bot merged commit 4796e05 into nodejs:main May 28, 2024

nodejs-github-bot commented May 28, 2024

Copy link
Copy Markdown
Collaborator

Landed in 4796e05

targos pushed a commit that referenced this pull request Jun 1, 2024
test_runner,doc: align documentation with actual stdout/stderr behavior
c249289 
PR-URL: #53131
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Jun 7, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
test_runner,doc: align documentation with actual stdout/stderr behavior
e82d2eb 
PR-URL: nodejs#53131
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
test_runner,doc: align documentation with actual stdout/stderr behavior
3a4a0eb 
PR-URL: #53131
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito mentioned this pull request Jul 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
aduh95 aduh95 approved these changes
atlowChemi atlowChemi approved these changes
benjamingr Awaiting requested review from benjamingr

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL