Commit 3acc89f
deps: V8: backport cd21f71f9cb5
Original commit message:
[parser] Validate destructuring assignment pattern in correct classifier
Previously we'd first accumulate errors to the parent and validate the
destructuring pattern in the parent. In the case of ParseArguments this
will invalidly propagate binding pattern errors from one argument to the
next. The reason why ParseArguments keeps track of binding pattern errors
is because it could also be used to parse async arrow function parameters.
If we see async(a,b) we don't yet know whether this is the head of an
async arrow function, or a call to async with arguments a and b.
Bug: v8:8241
Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f
Reviewed-on: https://chromium-review.googlesource.com/c/1296229
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56887}
Refs: v8/v8@cd21f71
Fixes: #23142
PR-URL: #33862
Reviewed-By: Richard Lau <riclau@uk.ibm.com>1 parent 89a306b commit 3acc89f
3 files changed
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -33,7 +33,7 @@ | |||
| 33 | 33 | ||
| 34 | 34 | # Reset this number to 0 on major V8 upgrades. | |
| 35 | 35 | # Increment by one for each non-official patch applied to deps/v8. | |
| 36 | - 'v8_embedder_string': '-node.57', | ||
| 36 | + 'v8_embedder_string': '-node.58', | ||
| 37 | 37 | ||
| 38 | 38 | # Enable disassembler for `--print-code` v8 options | |
| 39 | 39 | 'v8_enable_disassembler': 1, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2977,13 +2977,13 @@ ParserBase<Impl>::ParseAssignmentExpression(bool accept_IN, bool* ok) { | |||
| 2977 | 2977 | // This is definitely not an expression so don't accumulate | |
| 2978 | 2978 | // expression-related errors. | |
| 2979 | 2979 | productions &= ~ExpressionClassifier::ExpressionProduction; | |
| 2980 | + ValidateAssignmentPattern(CHECK_OK); | ||
| 2980 | 2981 | } | |
| 2981 | 2982 | ||
| 2982 | 2983 | Accumulate(productions); | |
| 2983 | 2984 | if (!Token::IsAssignmentOp(peek())) return expression; | |
| 2984 | 2985 | ||
| 2985 | 2986 | if (is_destructuring_assignment) { | |
| 2986 | - ValidateAssignmentPattern(CHECK_OK); | ||
| 2987 | 2987 | } else { | |
| 2988 | 2988 | expression = CheckAndRewriteReferenceExpression( | |
| 2989 | 2989 | expression, lhs_beg_pos, scanner()->location().end_pos, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,6 @@ | |||
| 1 | + // Copyright 2018 the V8 project authors. All rights reserved. | ||
| 2 | + // Use of this source code is governed by a BSD-style license that can be | ||
| 3 | + // found in the LICENSE file. | ||
| 4 | + | ||
| 5 | + function f(x) { } | ||
| 6 | + f(x=>x, [x,y] = [1,2]); | ||
0 commit comments