[v10.x] deps: V8: backport cd21f71f9cb5 - #33862
Closed
targos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Original commit message:
[parser] Validate destructuring assignment pattern in correct classifier
Previously we'd first accumulate errors to the parent and validate the
destructuring pattern in the parent. In the case of ParseArguments this
will invalidly propagate binding pattern errors from one argument to the
next. The reason why ParseArguments keeps track of binding pattern errors
is because it could also be used to parse async arrow function parameters.
If we see async(a,b) we don't yet know whether this is the head of an
async arrow function, or a call to async with arguments a and b.
Bug: v8:8241
Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f
Reviewed-on: https://chromium-review.googlesource.com/c/1296229
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#56887}
Refs: v8/v8@cd21f71
Fixes: nodejs#23142
Copy link
Copy Markdown
Member
Author
|
/cc @nodejs/lts |
Sorry, something went wrong.
richardlau
approved these changes
Jun 16, 2020
Comment thread
deps/v8/src/parsing/parser-base.h
Comment on lines
2986
to
2987
| if (is_destructuring_assignment) { | ||
| ValidateAssignmentPattern(CHECK_OK); | ||
| } else { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
:(
(I guess we should keep the empty if block on the off chance we'd need to backport anything else onto this file in the future.)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Is this important enough for a maintenance release? Seems like this parser error has existed as long as 10.x has |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Maybe not, but if there is a release for another reason, why not include this with it? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Should be fine to land on staging and if there is a future maintenance release to fix non security stuff we can ship it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
pushed a commit
that referenced
this pull request
Jul 1, 2020
Original commit message:
[parser] Validate destructuring assignment pattern in correct classifier
Previously we'd first accumulate errors to the parent and validate the
destructuring pattern in the parent. In the case of ParseArguments this
will invalidly propagate binding pattern errors from one argument to the
next. The reason why ParseArguments keeps track of binding pattern errors
is because it could also be used to parse async arrow function parameters.
If we see async(a,b) we don't yet know whether this is the head of an
async arrow function, or a call to async with arguments a and b.
Bug: v8:8241
Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f
Reviewed-on: https://chromium-review.googlesource.com/c/1296229
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56887}
Refs: v8/v8@cd21f71
Fixes: #23142
PR-URL: #33862
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
31 tasks
This was referenced Jul 3, 2020
This was referenced Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
[parser] Validate destructuring assignment pattern in correct classifier Previously we'd first accumulate errors to the parent and validate the destructuring pattern in the parent. In the case of ParseArguments this will invalidly propagate binding pattern errors from one argument to the next. The reason why ParseArguments keeps track of binding pattern errors is because it could also be used to parse async arrow function parameters. If we see async(a,b) we don't yet know whether this is the head of an async arrow function, or a call to async with arguments a and b. Bug: v8:8241 Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f Reviewed-on: https://chromium-review.googlesource.com/c/1296229 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56887}Refs: v8/v8@cd21f71
Fixes: #23142