Commit 3daced7
doc: remove "make that" from onboarding.md
Refs: nodejs/remark-preset-lint-node#16
PR-URL: #28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 79f23b5 commit 3daced7
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -124,7 +124,7 @@ onboarding session. | |||
| 124 | 124 | * Be aware: Your opinion carries a lot of weight! | |
| 125 | 125 | * Nits (requests for small changes that are not essential) are fine, but try to | |
| 126 | 126 | avoid stalling the pull request. | |
| 127 | - * Note that they are nits when you comment: `Nit: change foo() to bar().` | ||
| 127 | + * Identify them as nits when you comment: `Nit: change foo() to bar().` | ||
| 128 | 128 | * If they are stalling the pull request, fix them yourself on merge. | |
| 129 | 129 | * Insofar as possible, issues should be identified by tools rather than human | |
| 130 | 130 | reviewers. If you are leaving comments about issues that could be identified | |
@@ -191,7 +191,7 @@ onboarding session. | |||
| 191 | 191 | ||
| 192 | 192 | See the Collaborator Guide: [Landing Pull Requests][]. | |
| 193 | 193 | ||
| 194 | - Note that commits in one PR that belong to one logical change should | ||
| 194 | + Commits in one PR that belong to one logical change should | ||
| 195 | 195 | be squashed. It is rarely the case in onboarding exercises, so this | |
| 196 | 196 | needs to be pointed out separately during the onboarding. | |
| 197 | 197 | ||
0 commit comments