FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove "note that" from docs by Trott · Pull Request #28329 · nodejs/node · GitHub

/ node Public

doc: remove "note that" from docs - #28329

Closed
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:note-that-no
ConversationCommits (0)ChecksFiles changed
Closed

doc: remove "note that" from docs#28329
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:note-that-no

Conversation

Trott commented Jun 20, 2019

Copy link
Copy Markdown
Member

This is in preparation for nodejs/remark-preset-lint-node#16.

This conflicts with a current PR from @cjihrig but that's no big deal because when that lands, it just means we need to remove a single commit from this PR.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jun 20, 2019
Trott removed the build Issues and PRs related to build files or the CI. label Jun 20, 2019

nodejs-github-bot commented Jun 20, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24022/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 20, 2019

nodejs-github-bot commented Jun 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24030/

nodejs-github-bot commented Jun 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24031/

nodejs-github-bot commented Jun 22, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24047/

Trott commented Jun 22, 2019

Copy link
Copy Markdown
Member Author

Rebased to resolve conflict. Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3703/

Trott closed this Jun 23, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remote "note that" from BUILDING.md
dc5eb64 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from CPP_STYLE_GUIDE.md
6f15029 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from releases.md
0090798 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "make that" from onboarding.md
73d22d1 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from writing-tests.md
ca27625 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from writing-and-running-benchmarks.md
68cfa56 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from using-symbols.md
ebf5822 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from maintaining-the-build-files.md
73daba8 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from maintaining-V8.md
c067fdb 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from pull-requests.md
96fd0a0 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from zlib.md
ea069e8 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from util.md
e05f722 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from url.md
ecead5f 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott added a commit to Trott/io.js that referenced this pull request Jun 23, 2019
doc: remove "note that" from tty.md
5df70e0 
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
vsemozhetbyt mentioned this pull request Aug 2, 2019
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+1 more reviewer
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL