Commit 3ec3c32
src: fix crypto.pbkdf2 callback error argument
Callbacks should always return `null` instead of `undefined` if no
error occurred.
PR-URL: #18458
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent e8a75ee commit 3ec3c32
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5599,7 +5599,7 @@ void PBKDF2Request::Work(uv_work_t* work_req) { | |||
| 5599 | 5599 | ||
| 5600 | 5600 | void PBKDF2Request::After(Local<Value> (*argv)[2]) { | |
| 5601 | 5601 | if (success_) { | |
| 5602 | - (*argv)[0] = Undefined(env()->isolate()); | ||
| 5602 | + (*argv)[0] = Null(env()->isolate()); | ||
| 5603 | 5603 | (*argv)[1] = Buffer::New(env(), key_, keylen_).ToLocalChecked(); | |
| 5604 | 5604 | key_ = nullptr; | |
| 5605 | 5605 | keylen_ = 0; | |
0 commit comments