crypto: callback's error of crypto.pbkdf2 is set to undefined - #18458
Closed
BufoViridis wants to merge 1 commit into
Closed
crypto: callback's error of crypto.pbkdf2 is set to undefined#18458BufoViridis wants to merge 1 commit into
BufoViridis wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
As the documentation for crypto.pbkdf2 (https://nodejs.org/dist/latest-v8.x/docs/api/crypto.html#crypto_crypto_pbkdf2_password_salt_iterations_keylen_digest_callback) say, the function on success will return the first argument set to null and not undefined.
Copy link
Copy Markdown
Member
|
cc @nodejs/crypto, are we being consistent here? |
Sorry, something went wrong.
bnoordhuis
approved these changes
Jan 30, 2018
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM but a regression test would be nice.
@tniessen Most callbacks in core use null.
Sorry, something went wrong.
tniessen
approved these changes
Jan 30, 2018
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with @bnoordhuis' comment.
Sorry, something went wrong.
indutny
approved these changes
Jan 30, 2018
indutny
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The commit message should be refined when landing. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Jan 31, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 6, 2018
Callbacks should always return `null` instead of `undefined` if no error occurred. PR-URL: nodejs#18458 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in 6a29630 @BufoViridis thanks a lot! I fixed the subsystem and the commit message according to our guidlines while landing the PR. |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Callbacks should always return `null` instead of `undefined` if no error occurred. PR-URL: #18458 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Callbacks should always return `null` instead of `undefined` if no error occurred. PR-URL: #18458 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Callbacks should always return `null` instead of `undefined` if no error occurred. PR-URL: #18458 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 13, 2018
Callbacks should always return `null` instead of `undefined` if no error occurred. PR-URL: #18458 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Callbacks should always return `null` instead of `undefined` if no error occurred. PR-URL: nodejs#18458 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the documentation for crypto.pbkdf2 states, the function on success will set the first argument to null.
Checklist
Affected core subsystem(s)
crypto