Commit 420feb4
crypto: remove INT_MAX restriction in randomBytes
This restriction was due to an implementation detail in CSPRNG(). Now
that CSPRNG() properly handles lengths exceeding INT_MAX, remove this
artificial restriction.
Refs: #47515
PR-URL: #47559
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>1 parent 7f7735c commit 420feb4
1 file changed
Lines changed: 0 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -39,7 +39,6 @@ Maybe<bool> RandomBytesTraits::AdditionalConfig( | |||
| 39 | 39 | const FunctionCallbackInfo<Value>& args, | |
| 40 | 40 | unsigned int offset, | |
| 41 | 41 | RandomBytesConfig* params) { | |
| 42 | - Environment* env = Environment::GetCurrent(args); | ||
| 43 | 42 | CHECK(IsAnyByteSource(args[offset])); // Buffer to fill | |
| 44 | 43 | CHECK(args[offset + 1]->IsUint32()); // Offset | |
| 45 | 44 | CHECK(args[offset + 2]->IsUint32()); // Size | |
@@ -51,11 +50,6 @@ Maybe<bool> RandomBytesTraits::AdditionalConfig( | |||
| 51 | 50 | CHECK_GE(byte_offset + size, byte_offset); // Overflow check. | |
| 52 | 51 | CHECK_LE(byte_offset + size, in.size()); // Bounds check. | |
| 53 | 52 | ||
| 54 | - if (UNLIKELY(size > INT_MAX)) { | ||
| 55 | - THROW_ERR_OUT_OF_RANGE(env, "buffer is too large"); | ||
| 56 | - return Nothing<bool>(); | ||
| 57 | - } | ||
| 58 | - | ||
| 59 | 53 | params->buffer = in.data() + byte_offset; | |
| 60 | 54 | params->size = size; | |
| 61 | 55 | ||
0 commit comments