FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: remove INT_MAX restriction in randomBytes by tniessen · Pull Request #47559 · nodejs/node · GitHub

/ node Public

crypto: remove INT_MAX restriction in randomBytes - #47559

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:crypto-random-bytes-remove-intmax-restriction
Apr 17, 2023
ConversationCommits (1)ChecksFiles changed
Merged

crypto: remove INT_MAX restriction in randomBytes#47559
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:crypto-random-bytes-remove-intmax-restriction

Conversation

tniessen commented Apr 14, 2023

Copy link
Copy Markdown
Member

This restriction was due to an implementation detail in CSPRNG(). Now that CSPRNG() properly handles lengths exceeding INT_MAX, remove this artificial restriction.

Refs: #47515

crypto: remove INT_MAX restriction in randomBytes
3d7f4ee 
This restriction was due to an implementation detail in CSPRNG(). Now
that CSPRNG() properly handles lengths exceeding INT_MAX, remove this
artificial restriction.

Refs: nodejs#47515
tniessen added crypto Issues and PRs related to the crypto subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. blocked PRs that are blocked by other issues or PRs. labels Apr 14, 2023

nodejs-github-bot commented Apr 14, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 14, 2023

This comment was marked as outdated.

Sign in to view

bnoordhuis commented Apr 15, 2023

Copy link
Copy Markdown
Member

So... on the one hand I feel arbitrary limitations are bad. On the other hand, there isn't ever a good reason to request so much random data. It's more likely the result of buggy code than really wanting to grab gigabytes of randomness.

Bugs like that are also angle for resource exhaustion bugs (thread pool starvation in this case) so ceteris paribus rather than increasing the limit I suggest lowering it.

tniessen commented Apr 15, 2023

Copy link
Copy Markdown
Member Author

That's a valid point, but if someone wants to introduce an explicit smaller limit (and for a different reason), I think that should be a separate discussion/change, especially considering that it would be semver-major.

bnoordhuis commented Apr 15, 2023

Copy link
Copy Markdown
Member

Fair enough.

tniessen added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Apr 15, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2023

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51301/

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2023
nodejs-github-bot merged commit b342a1b into nodejs:main Apr 17, 2023

nodejs-github-bot commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in b342a1b

github-actions Bot mentioned this pull request Apr 18, 2023
Open
35 tasks
targos pushed a commit that referenced this pull request May 2, 2023
crypto: remove INT_MAX restriction in randomBytes
420feb4 
This restriction was due to an implementation detail in CSPRNG(). Now
that CSPRNG() properly handles lengths exceeding INT_MAX, remove this
artificial restriction.

Refs: #47515
PR-URL: #47559
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
crypto: remove INT_MAX restriction in randomBytes
a97a6f5 
This restriction was due to an implementation detail in CSPRNG(). Now
that CSPRNG() properly handles lengths exceeding INT_MAX, remove this
artificial restriction.

Refs: #47515
PR-URL: #47559
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
crypto: remove INT_MAX restriction in randomBytes
e2292f9 
This restriction was due to an implementation detail in CSPRNG(). Now
that CSPRNG() properly handles lengths exceeding INT_MAX, remove this
artificial restriction.

Refs: nodejs#47515
PR-URL: nodejs#47559
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL