process: register the inspector async hooks in bootstrap/node.js · nodejs/node@42fc754 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 42fc754

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

BridgeAR

committed

process: register the inspector async hooks in bootstrap/node.js

So it's easier to tell the side effects of this setup. PR-URL: #25443 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 3061cb5 commit 42fc754
Copy full SHA for 42fc754

2 files changed

+9-10Lines changed: 9 additions & 10 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • bootstrap
    • node.js
  • inspector_async_hook.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/bootstrap/node.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/node.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -151,7 +151,11 @@ function startup() {
151	151	}
152	152
153	153	if (config.hasInspector) {
154		- NativeModule.require('internal/inspector_async_hook').setup();
	154	+ const {
	155	+ enable,
	156	+ disable
	157	+ } = NativeModule.require('internal/inspector_async_hook');
	158	+ internalBinding('inspector').registerAsyncHook(enable, disable);
155	159	}
156	160
157	161	// If the process is spawned with env NODE_CHANNEL_FD, it's probably

Collapse file

‎lib/internal/inspector_async_hook.js‎

Copy file name to clipboardExpand all lines: lib/internal/inspector_async_hook.js

+4-9Lines changed: 4 additions & 9 deletions

Original file line number	Diff line number	Diff line change
@@ -1,16 +1,10 @@
1	1	'use strict';
2	2
3		- const inspector = internalBinding('inspector');
4		-
5		- if (!inspector || !inspector.asyncTaskScheduled) {
6		- exports.setup = function() {};
7		- return;
8		- }
9		-
10	3	let hook;
11	4	let config;
12	5
13	6	function lazyHookCreation() {
	7	+ const inspector = internalBinding('inspector');
14	8	const { createHook } = require('async_hooks');
15	9	config = internalBinding('config');
16	10
@@ -72,6 +66,7 @@ function disable() {
72	66	hook.disable();
73	67	}
74	68
75		- exports.setup = function() {
76		- inspector.registerAsyncHook(enable, disable);
	69	+ module.exports = {
	70	+ enable,
	71	+ disable
77	72	};

0 commit comments

Comments

0 (0)