FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

process: register the inspector async hooks in bootstrap/node.js by joyeecheung · Pull Request #25443 · nodejs/node · GitHub

/ node Public

process: register the inspector async hooks in bootstrap/node.js - #25443

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:refactor-iah
Closed

process: register the inspector async hooks in bootstrap/node.js#25443
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:refactor-iah

Conversation

Copy link
Copy Markdown
Member

So it's easier to tell the side effects of this setup.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

So it's easier to tell the side effects of this setup.

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member Author

joyeecheung added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 14, 2019
addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Jan 14, 2019

Copy link
Copy Markdown
Member

danbev commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

Re-run of failing node-test-commit-arm
Re-run of failing node-test-commit-windows-fanned

joyeecheung commented Jan 16, 2019
edited by danbev
Loading

Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member Author

Landed in 6b2af91

joyeecheung added a commit that referenced this pull request Jan 16, 2019
So it's easier to tell the side effects of this setup.

PR-URL: #25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jan 16, 2019
So it's easier to tell the side effects of this setup.

PR-URL: #25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR mentioned this pull request Jan 16, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
So it's easier to tell the side effects of this setup.

PR-URL: nodejs#25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
So it's easier to tell the side effects of this setup.

PR-URL: nodejs#25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL