module: fix incorrect formatting in require(esm) cycle error message · nodejs/node@44c5718 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 44c5718

Browse filesBrowse the repository at this point in the historyBrowse files

haykam821

authored and

aduh95

committed

module: fix incorrect formatting in require(esm) cycle error message

Fixes: #57451 PR-URL: #57453 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 01cad99 commit 44c5718
Copy full SHA for 44c5718

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/modules/esm
  • loader.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/modules/esm/loader.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/loader.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -408,8 +408,8 @@ class ModuleLoader {
408	408	if (parentFilename) {
409	409	message += ` (from ${parentFilename})`;
410	410	}
411		- message += 'A cycle involving require(esm) is disallowed to maintain ';
412		- message += 'invariants madated by the ECMAScript specification';
	411	+ message += ' A cycle involving require(esm) is not allowed to maintain ';
	412	+ message += 'invariants mandated by the ECMAScript specification. ';
413	413	message += 'Try making at least part of the dependency in the graph lazily loaded.';
414	414	throw new ERR_REQUIRE_CYCLE_MODULE(message);
415	415

0 commit comments

Comments

0 (0)