FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

module: fix incorrect formatting in require(esm) cycle error message by haykam821 · Pull Request #57453 · nodejs/node · GitHub

/ node Public

module: fix incorrect formatting in require(esm) cycle error message - #57453

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
haykam821:fix-require-esm-error-cycle-message-formatting
Apr 9, 2025
ConversationCommits (1)ChecksFiles changed
Merged

module: fix incorrect formatting in require(esm) cycle error message#57453
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
haykam821:fix-require-esm-error-cycle-message-formatting

Conversation

haykam821 commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

This pull request includes minor wording and punctuation tweaks to fix the formatting of the require(esm) cycle error message. The message still seems a bit confusing to me, but these changes should at least be an improvement.

I am not sure whether tests should be implemented for this change, as the original error message didn't have tests either, but I can try my hand at implementing some if that would be preferred.

Fixes: #57451

nodejs-github-bot commented Mar 14, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Mar 14, 2025
BridgeAR approved these changes Mar 14, 2025
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Do you mind adding a test for this as well? I didn't check, I guess we already have a spot where this is checked or at least triggered in tests and we can just test for the correct value to be there.

codecov Bot commented Mar 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (3329efe) to head (ce68ab6).
Report is 642 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57453   +/-   ##
=======================================
  Coverage   90.20%   90.21%           
=======================================
  Files         629      629           
  Lines      184948   184948           
  Branches    36204    36211    +7     
=======================================
+ Hits       166837   166843    +6     
+ Misses      11057    11045   -12     
- Partials     7054     7060    +6
Files with missing lines Coverage Δ
lib/internal/modules/esm/loader.js 95.04% <100.00%> (ø)

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v20.x labels Mar 14, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2025

nodejs-github-bot commented Mar 14, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65743/

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2025

nodejs-github-bot commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66115/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2025
nodejs-github-bot merged commit bc09144 into nodejs:main Apr 9, 2025

nodejs-github-bot commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

Landed in bc09144

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
module: fix incorrect formatting in require(esm) cycle error message
81ad5b2 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
module: fix incorrect formatting in require(esm) cycle error message
0049147 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
module: fix incorrect formatting in require(esm) cycle error message
29bfd78 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
module: fix incorrect formatting in require(esm) cycle error message
2716c24 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
module: fix incorrect formatting in require(esm) cycle error message
44c4ceb 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
module: fix incorrect formatting in require(esm) cycle error message
bd7b94f 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
module: fix incorrect formatting in require(esm) cycle error message
44c5718 
Fixes: #57451
PR-URL: #57453
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

marco-ippolito commented Jun 5, 2025

Copy link
Copy Markdown
Member

This commit requires a manual backport to v20.x

ghost mentioned this pull request Jun 8, 2025
Closed
joyeecheung mentioned this pull request Aug 17, 2025
Closed
9 tasks
joyeecheung mentioned this pull request Aug 17, 2025
Closed
marco-ippolito pushed a commit to joyeecheung/node that referenced this pull request Aug 20, 2025
module: fix incorrect formatting in require(esm) cycle error message
feb6167 
Fixes: nodejs#57451
PR-URL: nodejs#57453
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito mentioned this pull request Aug 20, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
module: fix incorrect formatting in require(esm) cycle error message
1186650 
Fixes: #57451
PR-URL: #57453
Backport-PR-URL: #59504
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #52697
marco-ippolito pushed a commit that referenced this pull request Aug 23, 2025
module: fix incorrect formatting in require(esm) cycle error message
bbbad9a 
Fixes: #57451
PR-URL: #57453
Backport-PR-URL: #59504
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #52697
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
module: fix incorrect formatting in require(esm) cycle error message
1b1576b 
Fixes: #57451
PR-URL: #57453
Backport-PR-URL: #59504
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #52697
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
module: fix incorrect formatting in require(esm) cycle error message
41d8b72 
Fixes: #57451
PR-URL: #57453
Backport-PR-URL: #59504
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #52697
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
module: fix incorrect formatting in require(esm) cycle error message
dd55033 
Fixes: #57451
PR-URL: #57453
Backport-PR-URL: #59504
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #52697
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
module: fix incorrect formatting in require(esm) cycle error message
badba50 
Fixes: #57451
PR-URL: #57453
Backport-PR-URL: #59504
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #52697
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
BridgeAR BridgeAR approved these changes
marco-ippolito marco-ippolito approved these changes
jakecastelli jakecastelli approved these changes
+1 more reviewer
jsumners-nr jsumners-nr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bad formatting in require(esm) module cycle error message

9 participants

Back | FazBrowse Home | New Git URL