Commit 45b59e5
lib: fix naming convention of Symbol
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
PR-URL: #53387
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent f4efb7f commit 45b59e5
3 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -65,7 +65,7 @@ const kWeakHandler = Symbol('kWeak'); | |||
| 65 | 65 | const kResistStopPropagation = Symbol('kResistStopPropagation'); | |
| 66 | 66 | ||
| 67 | 67 | const kHybridDispatch = SymbolFor('nodejs.internal.kHybridDispatch'); | |
| 68 | - const kRemoveWeakListenerHelper = Symbol('nodejs.internal.removeWeakListenerHelper'); | ||
| 68 | + const kRemoveWeakListenerHelper = Symbol('kRemoveWeakListenerHelper'); | ||
| 69 | 69 | const kCreateEvent = Symbol('kCreateEvent'); | |
| 70 | 70 | const kNewListener = Symbol('kNewListener'); | |
| 71 | 71 | const kRemoveListener = Symbol('kRemoveListener'); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,7 +4,7 @@ const { | |||
| 4 | 4 | Symbol, | |
| 5 | 5 | } = primordials; | |
| 6 | 6 | ||
| 7 | - const kFirstEventParam = Symbol('nodejs.kFirstEventParam'); | ||
| 7 | + const kFirstEventParam = Symbol('kFirstEventParam'); | ||
| 8 | 8 | ||
| 9 | 9 | module.exports = { | |
| 10 | 10 | kFirstEventParam, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -34,7 +34,7 @@ const { | |||
| 34 | 34 | kIsNodeError, | |
| 35 | 35 | } = require('internal/errors'); | |
| 36 | 36 | ||
| 37 | - const kSensitiveHeaders = Symbol('nodejs.http2.sensitiveHeaders'); | ||
| 37 | + const kSensitiveHeaders = Symbol('sensitiveHeaders'); | ||
| 38 | 38 | const kSocket = Symbol('socket'); | |
| 39 | 39 | const kProxySocket = Symbol('proxySocket'); | |
| 40 | 40 | const kRequest = Symbol('request'); | |
0 commit comments