lib: fix naming convention of Symbol - #53387
Merged
nodejs-github-bot merged 2 commits intoJun 10, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
`node.js` prefix is used for global symbol(`Symbol.for`). So remove `node.js` prefix from `Symbol` usage. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
mcollina
approved these changes
Jun 8, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
This comment was marked as outdated.
lpinca
approved these changes
Jun 8, 2024
Comment thread
lib/internal/event_target.js
Outdated
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
H4ad
approved these changes
Jun 9, 2024
marco-ippolito
approved these changes
Jun 9, 2024
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
`node.js` prefix is used for global symbol(`Symbol.for`). So remove `node.js` prefix from `Symbol` usage. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring PR-URL: #53387 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
`node.js` prefix is used for global symbol(`Symbol.for`). So remove `node.js` prefix from `Symbol` usage. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring PR-URL: nodejs#53387 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
`node.js` prefix is used for global symbol(`Symbol.for`). So remove `node.js` prefix from `Symbol` usage. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring PR-URL: #53387 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node.js prefix is used for global symbol(Symbol.for). So remove node.js prefix from Symbol usage.
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
node/doc/contributing/using-symbols.md
Lines 67 to 68 in 50695e5