Commit 45e7b10
test: fix 'checks' validation test for checkPrime
This test had two problems:
* The first argument was a number in both cases, which is what caused
the (expected) ERR_INVALID_ARG_TYPE error -- the validity of the
'checks' option was not actually verified at all. Thus, the first
argument should be valid for this particular test.
* The function returned by common.mustNotCall() was passed to
assert.throws() as a third argument instead of being passed to
checkPrime() as a third argument. (Isn't JavaScript great?) This again
led to the (expected) ERR_INVALID_ARG_TYPE error, but again, the
validity of the 'checks' option was not verified.
Fix both issues by ensuring that all arguments except the 'checks'
option are valid.
Refs: #36997
PR-URL: #47139
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 5749dfa commit 45e7b10
1 file changed
Lines changed: 9 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -229,14 +229,16 @@ generatePrime( | |||
| 229 | 229 | }); | |
| 230 | 230 | }); | |
| 231 | 231 | ||
| 232 | - ['hello', {}, []].forEach((i) => { | ||
| 233 | - assert.throws(() => checkPrime(2, { checks: i }), { | ||
| 234 | - code: 'ERR_INVALID_ARG_TYPE' | ||
| 235 | - }, common.mustNotCall()); | ||
| 236 | - assert.throws(() => checkPrimeSync(2, { checks: i }), { | ||
| 237 | - code: 'ERR_INVALID_ARG_TYPE' | ||
| 232 | + for (const checks of ['hello', {}, []]) { | ||
| 233 | + assert.throws(() => checkPrime(2n, { checks }, common.mustNotCall()), { | ||
| 234 | + code: 'ERR_INVALID_ARG_TYPE', | ||
| 235 | + message: /checks/ | ||
| 238 | 236 | }); | |
| 239 | - }); | ||
| 237 | + assert.throws(() => checkPrimeSync(2n, { checks }), { | ||
| 238 | + code: 'ERR_INVALID_ARG_TYPE', | ||
| 239 | + message: /checks/ | ||
| 240 | + }); | ||
| 241 | + } | ||
| 240 | 242 | ||
| 241 | 243 | assert(!checkPrimeSync(Buffer.from([0x1]))); | |
| 242 | 244 | assert(checkPrimeSync(Buffer.from([0x2]))); | |
0 commit comments