http, async_hooks: remove unneeded reference to wrapping resource · nodejs/node@49a07f7 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 639
• Pull requests 749
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 49a07f7

Browse filesBrowse the repository at this point in the historyBrowse files

Flarna

authored and

MylesBorins

committed

http, async_hooks: remove unneeded reference to wrapping resource

Remove the reference from handle to the unique/wrapping resource ReusedHandle as there is meanwhile a strong reference for all async resources in place via AsyncWarp::resource_. PR-URL: #32054 Refs: #30959 Refs: #30196 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1 parent 5bc5161 commit 49a07f7
Copy full SHA for 49a07f7

1 file changed

-8Lines changed: 0 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • _http_agent.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/_http_agent.js‎

Copy file name to clipboardExpand all lines: lib/_http_agent.js

-8Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -50,18 +50,10 @@ const kOnKeylog = Symbol('onkeylog');
50	50	// ClientRequest.onSocket(). The Agent is now *strictly*
51	51	// concerned with managing a connection pool.
52	52
53		- const kReusedHandle = Symbol('kReusedHandle');
54	53	class ReusedHandle {
55	54	constructor(type, handle) {
56	55	this.type = type;
57	56	this.handle = handle;
58		- // We need keep the resource object alive from this object, because
59		- // domains rely on GC of the resource object for lifetime tracking.
60		- // TODO(addaleax): This should really apply to all uses of
61		- // AsyncWrap::AsyncReset() when the resource is not the AsyncWrap object
62		- // itself. However, HTTPClientAsyncResource and HTTPServerAsyncResource
63		- // hold on to other objects, inhibiting GC.
64		- handle[kReusedHandle] = this;
65	57	}
66	58	}
67	59

0 commit comments

Comments

0 (0)