FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

async_hooks: add executionAsyncResource by Qard · Pull Request #30959 · nodejs/node · GitHub

/ node Public

async_hooks: add executionAsyncResource - #30959

Closed
Qard wants to merge 24 commits into
nodejs:masterfrom
Qard:current-resource
ConversationCommits (24)ChecksFiles changed
Closed

async_hooks: add executionAsyncResource#30959
Qard wants to merge 24 commits into
nodejs:masterfrom
Qard:current-resource

Conversation

Qard commented Dec 14, 2019

Copy link
Copy Markdown
Member

This is a rebase of #21313

With llhttp in Node.js, the http parser reuse code now gives each reuse an AsyncResource so the concerns of the original attempt at a "current resource" API are no longer valid, unblocking it from landing now. This is basically identical to the original PR with some minor changes to appease the linter and to shuffle around some bits that moved in timers refactoring.

I'm working on this so I can update #26540 to use this form of the current resource API, eliminating a potential memory leak concern.

cc @nodejs/diagnostics @nodejs/async_hooks

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Qard added lib / src Issues and PRs related to general changes in the lib or src directory. async_hooks Issues and PRs related to the async hooks subsystem. labels Dec 14, 2019
Qard mentioned this pull request Dec 14, 2019
Closed
4 tasks
mcollina approved these changes Dec 14, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, we should run the benchmark and see how it goes.

addaleax mentioned this pull request Dec 14, 2019
Closed
addaleax requested changes Dec 14, 2019
View reviewed changes
Comment thread src/api/callback.cc Outdated
Comment thread src/async_wrap.cc Outdated
puzpuzpuz reviewed Dec 16, 2019
View reviewed changes
Comment thread doc/api/async_hooks.md Outdated
Flarna reviewed Dec 16, 2019
View reviewed changes
Comment thread lib/internal/async_hooks.js Outdated
Flarna reviewed Dec 16, 2019
View reviewed changes

Flarna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think the calls to emitBefore() and emitAfter() in class AsyncResource needs to be also adapted to pass the current resource.

puzpuzpuz mentioned this pull request Dec 18, 2019
Closed
4 tasks
addaleax reviewed Dec 18, 2019
View reviewed changes
Comment thread src/env.h Outdated

puzpuzpuz commented Dec 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@Qard
I've implemented a continuation local storage based on the executionAsyncResource() function. See #31016

Decided that you might be interested as you described this idea in #26540

jasnell reviewed Dec 18, 2019
View reviewed changes
Comment thread doc/api/async_hooks.md Outdated

Qard commented Dec 19, 2019

Copy link
Copy Markdown
Member Author

I've got the stack form almost working, but the parallel/test-heapdump-async-hooks-init-promise.js test is failing and I haven't yet figured out why. I'll continue looking into it, but if anyone else has any ideas, let me know.

Qard force-pushed the current-resource branch 2 times, most recently from a457680 to 4788019 Compare December 19, 2019 01:36

Qard commented Dec 19, 2019

Copy link
Copy Markdown
Member Author

Nevermind, forgot I had something commented out. It all works now. Just need to update the docs, as James requested, and it should be ready for another review. 😅

nodejs-github-bot commented Dec 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27804/

Qard force-pushed the current-resource branch 2 times, most recently from 969c029 to 793282f Compare December 19, 2019 06:17
Flarna reviewed Dec 19, 2019
View reviewed changes
Comment thread lib/async_hooks.js
Flarna reviewed Dec 19, 2019
View reviewed changes
Comment thread doc/api/async_hooks.md Outdated
Flarna reviewed Dec 19, 2019
View reviewed changes
Comment thread doc/api/async_hooks.md Outdated
Flarna reviewed Dec 19, 2019
View reviewed changes
Comment thread src/async_wrap.cc Outdated

Flarna commented Dec 19, 2019

Copy link
Copy Markdown
Member

Thanks for working on this!

I left some comments but non of them are intended to block this PR as they can be addressed in a separate PR.

As far as I remember there is still one place left where an AsyncWrap is reused in node_file.cc but I'm quite sure that this can be easily fixed via a followup PR similar as the reuse in HTTP agent and parser.

targos added backported-to-v12.x and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. review wanted PRs that need reviews. labels Mar 7, 2020
puzpuzpuz mentioned this pull request Mar 7, 2020
Closed
4 tasks
addaleax pushed a commit that referenced this pull request Mar 11, 2020
http, async_hooks: remove unneeded reference to wrapping resource
943887f 
Remove the reference from handle to the unique/wrapping resource
ReusedHandle as there is meanwhile a strong reference for all async
resources in place via AsyncWarp::resource_.

PR-URL: #32054
Refs: #30959
Refs: #30196
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
http, async_hooks: remove unneeded reference to wrapping resource
3119bbe 
Remove the reference from handle to the unique/wrapping resource
ReusedHandle as there is meanwhile a strong reference for all async
resources in place via AsyncWarp::resource_.

PR-URL: #32054
Refs: #30959
Refs: #30196
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Mar 11, 2020
async_hooks: avoid resource reuse by FileHandle
c145b29 
Wrap reused read_wrap in a unique async resource to ensure that
executionAsyncResource() is not ambiguous.

PR-URL: #31972
Refs: #30959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
http, async_hooks: remove unneeded reference to wrapping resource
49a07f7 
Remove the reference from handle to the unique/wrapping resource
ReusedHandle as there is meanwhile a strong reference for all async
resources in place via AsyncWarp::resource_.

PR-URL: #32054
Refs: #30959
Refs: #30196
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
async_hooks: avoid resource reuse by FileHandle
478f1e7 
Wrap reused read_wrap in a unique async resource to ensure that
executionAsyncResource() is not ambiguous.

PR-URL: #31972
Refs: #30959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
legendecas mentioned this pull request Mar 20, 2020
Closed
puzpuzpuz pushed a commit to puzpuzpuz/node that referenced this pull request Apr 14, 2020
async_hooks: add executionAsyncResource
cd36fc7 
Remove the need for the destroy hook in the basic APM case.

Co-authored-by: Stephen Belanger <admin@stephenbelanger.com>
PR-URL: nodejs#30959
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request May 2, 2020
Merged
kibertoad mentioned this pull request May 15, 2020
Closed
puzpuzpuz mentioned this pull request Jul 25, 2020
Merged
Flarna mentioned this pull request Aug 20, 2020
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
Flarna Flarna approved these changes
mcollina mcollina approved these changes
jasnell jasnell approved these changes
legendecas legendecas approved these changes
watson Awaiting requested review from watson
AndreasMadsen Awaiting requested review from AndreasMadsen
+3 more reviewers
wa-Nadoo wa-Nadoo left review comments
puzpuzpuz puzpuzpuz left review comments
vdeturckheim vdeturckheim approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL