test: increase wiggle room for memory in test-worker-resource-limits · nodejs/node@4c5eff9 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4c5eff9

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

test: increase wiggle room for memory in test-worker-resource-limits

PR-URL: #37901 Fixes: #37844 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent f055faf commit 4c5eff9
Copy full SHA for 4c5eff9

1 file changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-worker-resource-limits.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-worker-resource-limits.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-worker-resource-limits.js

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -35,9 +35,10 @@ if (!process.env.HAS_STARTED_WORKER) {
35	35	assert.deepStrictEqual(resourceLimits, testResourceLimits);
36	36	const array = [];
37	37	while (true) {
38		- // Leave 10 % wiggle room here.
	38	+ // Leave 10% wiggle room here, and 20% on debug builds.
	39	+ const wiggleRoom = common.buildType === 'Release' ? 1.1 : 1.2;
39	40	const usedMB = v8.getHeapStatistics().used_heap_size / 1024 / 1024;
40		- assert(usedMB < resourceLimits.maxOldGenerationSizeMb * 1.1);
	41	+ assert(usedMB < resourceLimits.maxOldGenerationSizeMb * wiggleRoom);
41	42
42	43	let seenSpaces = 0;
43	44	for (const { space_name, space_size } of v8.getHeapSpaceStatistics()) {

0 commit comments

Comments

0 (0)