FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: increase wiggle room for memory in test-worker-resource-limits by Trott · Pull Request #37901 · nodejs/node · GitHub

/ node Public

test: increase wiggle room for memory in test-worker-resource-limits - #37901

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:wiggle
ConversationCommits (1)ChecksFiles changed
Closed

test: increase wiggle room for memory in test-worker-resource-limits#37901
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:wiggle

Conversation

Trott commented Mar 25, 2021

Copy link
Copy Markdown
Member

Fixes: #37844

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 25, 2021

Trott commented Mar 25, 2021

Copy link
Copy Markdown
Member Author

Fast-track if 20% is enough to fix it on Debug builds?

Trott requested review from addaleax and danbev March 25, 2021 03:03

nodejs-github-bot commented Mar 25, 2021 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36957/ ✅

Trott requested a review from jasnell March 25, 2021 03:25
Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Mar 25, 2021
Trott mentioned this pull request Mar 25, 2021
Closed

danbev commented Mar 25, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'll take a look and link and test against OpenSSL 3.0 now ✔️

danbev pushed a commit that referenced this pull request Mar 25, 2021
test: increase wiggle room for memory in test-worker-resource-limits
498c6b1 
PR-URL: #37901
Fixes: #37844
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

danbev commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Landed in 498c6b1

danbev closed this Mar 25, 2021
aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 25, 2021
ruyadorno pushed a commit that referenced this pull request Mar 29, 2021
test: increase wiggle room for memory in test-worker-resource-limits
796c308 
PR-URL: #37901
Fixes: #37844
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno pushed a commit that referenced this pull request Mar 30, 2021
test: increase wiggle room for memory in test-worker-resource-limits
76ebc4b 
PR-URL: #37901
Fixes: #37844
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
test: increase wiggle room for memory in test-worker-resource-limits
4c5eff9 
PR-URL: #37901
Fixes: #37844
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
Trott deleted the wiggle branch September 25, 2022 17:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 approved these changes
addaleax Awaiting requested review from addaleax
jasnell Awaiting requested review from jasnell
+1 more reviewer
danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky test-worker-resource-limits

4 participants

Back | FazBrowse Home | New Git URL