nodejs
diff --git a/‎lib/internal/http2/core.js‎
Lines changed: 3 additions & 3 deletions b/‎lib/internal/http2/core.js‎
Lines changed: 3 additions & 3 deletions
diff --git a/‎test/parallel/test-http2-ping.js‎
Lines changed: 4 additions & 3 deletions b/‎test/parallel/test-http2-ping.js‎
Lines changed: 4 additions & 3 deletions
@@ -1444,9 +1444,9 @@ class Http2Session extends EventEmitter {
     }
     if (payload) {
       validateBuffer(payload, 'payload');
-    }
-    if (payload && payload.length !== 8) {
-      throw new ERR_HTTP2_PING_LENGTH();
+      if (payload.byteLength !== 8) {
+        throw new ERR_HTTP2_PING_LENGTH();
+      }
     }
     validateFunction(callback, 'callback');
 
 
@@ -64,11 +64,11 @@ server.listen(0, common.mustCall(() => {
       })));
     }
     {
-      const payload = Buffer.from('abcdefgi');
+      const payload = new Uint16Array([1, 2, 3, 4]);
       assert(client.ping(payload, common.mustCall((err, duration, ret) => {
         assert.strictEqual(err, null);
         assert.strictEqual(typeof duration, 'number');
-        assert.deepStrictEqual(payload, ret);
+        assert.deepStrictEqual(payload.buffer, ret.buffer);
       })));
     }
 
@@ -99,7 +99,8 @@ server.listen(0, common.mustCall(() => {
     {
       const shortPayload = Buffer.from('abcdefg');
       const longPayload = Buffer.from('abcdefghi');
-      [shortPayload, longPayload].forEach((payloadWithInvalidLength) =>
+      const mismatchedPayload = new Uint32Array(8);
+      [shortPayload, longPayload, mismatchedPayload].forEach((payloadWithInvalidLength) =>
         assert.throws(
           () => client.ping(payloadWithInvalidLength),
           {
Original file line number	Diff line number	Diff line change
@@ -1444,9 +1444,9 @@ class Http2Session extends EventEmitter {
1444	1444	}
1445	1445	if (payload) {
1446	1446	validateBuffer(payload, 'payload');
1447		- }
1448		- if (payload && payload.length !== 8) {
1449		- throw new ERR_HTTP2_PING_LENGTH();
	1447	+ if (payload.byteLength !== 8) {
	1448	+ throw new ERR_HTTP2_PING_LENGTH();
	1449	+ }
1450	1450	}
1451	1451	validateFunction(callback, 'callback');
1452	1452
Original file line number	Diff line number	Diff line change
@@ -64,11 +64,11 @@ server.listen(0, common.mustCall(() => {
64	64	})));
65	65	}
66	66	{
67		- const payload = Buffer.from('abcdefgi');
	67	+ const payload = new Uint16Array([1, 2, 3, 4]);
68	68	assert(client.ping(payload, common.mustCall((err, duration, ret) => {
69	69	assert.strictEqual(err, null);
70	70	assert.strictEqual(typeof duration, 'number');
71		- assert.deepStrictEqual(payload, ret);
	71	+ assert.deepStrictEqual(payload.buffer, ret.buffer);
72	72	})));
73	73	}
74	74
@@ -99,7 +99,8 @@ server.listen(0, common.mustCall(() => {
99	99	{
100	100	const shortPayload = Buffer.from('abcdefg');
101	101	const longPayload = Buffer.from('abcdefghi');
102		- [shortPayload, longPayload].forEach((payloadWithInvalidLength) =>
	102	+ const mismatchedPayload = new Uint32Array(8);
	103	+ [shortPayload, longPayload, mismatchedPayload].forEach((payloadWithInvalidLength) =>
103	104	assert.throws(
104	105	() => client.ping(payloadWithInvalidLength),
105	106	{