FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: do not crash on mismatched ping buffer length by Renegade334 · Pull Request #60135 · nodejs/node · GitHub

/ node Public

http2: do not crash on mismatched ping buffer length - #60135

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:http2-ping-byte-length
Oct 8, 2025
ConversationCommits (1)ChecksFiles changed
Merged

http2: do not crash on mismatched ping buffer length#60135
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:http2-ping-byte-length

Conversation

Renegade334 commented Oct 6, 2025

Copy link
Copy Markdown
Member 
const session = require('http2').connect('http://localhost/')
session.ping(new Uint32Array(8), console.debug)

yields

  #  node[1898056]: static void node::http2::Http2Session::Ping(const v8::FunctionCallbackInfo<v8::Value>&) at ../src/node_http2.cc:3227
  #  Assertion failed: (payload.length()) == (8)

IOT instruction (core dumped)

nodejs-github-bot commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 6, 2025

codecov Bot commented Oct 7, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (b757a8f) to head (b0a2c8c).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60135      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.02%     
==========================================
  Files         703      703              
  Lines      207804   207804              
  Branches    40005    40006       +1     
==========================================
- Hits       183989   183952      -37     
- Misses      15817    15866      +49     
+ Partials     7998     7986      -12
Files with missing lines Coverage Δ
lib/internal/http2/core.js 95.20% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BridgeAR added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Oct 7, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2025

nodejs-github-bot commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69586/

mcollina approved these changes Oct 7, 2025
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2025
mcollina added lts-watch-v20.x lts-watch-v22.x PRs that may need to be released in v22.x and removed request-ci Add this label to start a Jenkins CI on a PR. needs-ci PRs that need a full CI run. labels Oct 7, 2025
richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
nodejs-github-bot merged commit 535efea into nodejs:main Oct 8, 2025
85 of 86 checks passed

nodejs-github-bot commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

Landed in 535efea

Renegade334 deleted the http2-ping-byte-length branch October 9, 2025 05:12
RafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 pushed a commit that referenced this pull request Oct 31, 2025
http2: do not crash on mismatched ping buffer length
5009021 
PR-URL: #60135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
github-actions Bot mentioned this pull request Nov 7, 2025
Closed
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
http2: do not crash on mismatched ping buffer length
65bec03 
PR-URL: #60135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
github-actions Bot mentioned this pull request Nov 7, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Nov 19, 2025
http2: do not crash on mismatched ping buffer length
20616f1 
PR-URL: #60135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito mentioned this pull request Nov 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
http2: do not crash on mismatched ping buffer length
2ccc9a6 
PR-URL: #60135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 mentioned this pull request Feb 22, 2026
Merged
marco-ippolito added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed lts-watch-v22.x PRs that may need to be released in v22.x labels Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
lpinca lpinca approved these changes
pimterry pimterry approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
RafaelGSS RafaelGSS approved these changes
gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. backported-to-v22.x PRs backported to the v22.x-staging branch. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL