tools: add read permission to workflows that read contents · nodejs/node@5014f22 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5014f22

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

marco-ippolito

committed

tools: add read permission to workflows that read contents

Not having this permission is OK because the repo is public, but on private forks, it fails the checkout step. PR-URL: #58255 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

1 parent 15bd0da commit 5014f22
Copy full SHA for 5014f22

2 files changed

+2Lines changed: 2 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • lint-release-proposal.yml
  • notify-on-push.yml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/lint-release-proposal.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/lint-release-proposal.yml

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -20,6 +20,7 @@ jobs:
20	20	lint-release-commit:
21	21	runs-on: ubuntu-slim
22	22	permissions:
	23	+ contents: read
23	24	pull-requests: read
24	25	steps:
25	26	- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

Collapse file

‎.github/workflows/notify-on-push.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/notify-on-push.yml

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -32,6 +32,7 @@ jobs:
32	32	name: Notify on Push on `main` that lacks metadata
33	33	if: github.repository == 'nodejs/node'
34	34	permissions:
	35	+ contents: read
35	36	pull-requests: write
36	37	# cannot use ubuntu-slim here because rtCamp/action-slack-notify is dockerized
37	38	runs-on: ubuntu-24.04-arm

0 commit comments

Comments

0 (0)