FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: add read permission to workflows that read contents by aduh95 · Pull Request #58255 · nodejs/node · GitHub

/ node Public

tools: add read permission to workflows that read contents - #58255

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:permission-contents-read
May 11, 2025
Merged

tools: add read permission to workflows that read contents#58255
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:permission-contents-read

Conversation

aduh95 commented May 9, 2025

Copy link
Copy Markdown
Contributor

Not having this permission is OK because the repo is public, but on private forks (e.g. the one where security releases are getting prepared), it fails at the checkout step.

Not having this permission is OK because the repo is public, but
on private forks, it fails the checkout step.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 9, 2025
LiviaMedeiros added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 10, 2025
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2025
nodejs-github-bot merged commit 6e222ed into nodejs:main May 11, 2025

Copy link
Copy Markdown
Collaborator

Landed in 6e222ed

aduh95 deleted the permission-contents-read branch May 12, 2025 05:50
targos pushed a commit that referenced this pull request May 16, 2025
Not having this permission is OK because the repo is public, but
on private forks, it fails the checkout step.

PR-URL: #58255
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 added a commit that referenced this pull request Jun 10, 2025
Not having this permission is OK because the repo is public, but
on private forks, it fails the checkout step.

PR-URL: #58255
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit that referenced this pull request Mar 2, 2026
Not having this permission is OK because the repo is public, but
on private forks, it fails the checkout step.

PR-URL: #58255
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit that referenced this pull request Mar 3, 2026
Not having this permission is OK because the repo is public, but
on private forks, it fails the checkout step.

PR-URL: #58255
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL