Commit 5298db4
build: run perfetto build and test on GHA
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #64721
Fixes: nodejs/diagnostics#654
Refs: #64565
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent e3eac7c commit 5298db4
3 files changed
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -141,20 +141,23 @@ jobs: | |||
| 141 | 141 | include: | |
| 142 | 142 | - runner: ubuntu-24.04 | |
| 143 | 143 | system: x86_64-linux | |
| 144 | + # Exercise the trace-event code against a perfetto-enabled V8. | ||
| 145 | + perfetto: true | ||
| 144 | 146 | # built separately in build-aarch64-linux-v8 | |
| 145 | 147 | # - runner: ubuntu-24.04-arm | |
| 146 | 148 | # system: aarch64-linux | |
| 147 | 149 | - runner: macos-15-intel | |
| 148 | 150 | system: x86_64-darwin | |
| 149 | 151 | - runner: macos-latest | |
| 150 | 152 | system: aarch64-darwin | |
| 151 | - name: '${{ matrix.system }}: with shared libraries' | ||
| 153 | + name: '${{ matrix.system }}: with shared libraries${{ matrix.perfetto && '' and perfetto'' || '''' }}' | ||
| 152 | 154 | uses: ./.github/workflows/build-shared.yml | |
| 153 | 155 | with: | |
| 154 | 156 | runner: ${{ matrix.runner }} | |
| 155 | 157 | with-sccache: ${{ github.base_ref == 'main' || github.ref_name == 'main' }} | |
| 156 | 158 | extra-nix-flags: | | |
| 157 | 159 | --arg useSeparateDerivationForV8 true \ | |
| 160 | + ${{ matrix.perfetto && '--arg withPerfetto true \' || '\' }} | ||
| 158 | 161 | ${{ endsWith(matrix.system, '-darwin') && '--arg withAmaro false --arg withLief false --arg withSQLite false --arg withFFI false --arg extraConfigFlags ''["--without-inspector" "--without-node-options"]'' \' || '\' }} | |
| 159 | 162 | secrets: | |
| 160 | 163 | CACHIX_AUTH_TOKEN: ${{ secrets.CACHIX_AUTH_TOKEN }} | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -19,6 +19,7 @@ | |||
| 19 | 19 | withFFI ? true, | |
| 20 | 20 | withSSL ? true, | |
| 21 | 21 | withTemporal ? false, | |
| 22 | + withPerfetto ? false, | ||
| 22 | 23 | sharedLibDeps ? ( | |
| 23 | 24 | import ./tools/nix/sharedLibDeps.nix { | |
| 24 | 25 | inherit | |
@@ -67,7 +68,8 @@ let | |||
| 67 | 68 | ) | |
| 68 | 69 | "--v8-${if withTemporal then "enable" else "disable"}-temporal-support" | |
| 69 | 70 | ] | |
| 70 | - ++ pkgs.lib.optional (withTemporal && useSharedTemporal) "--shared-temporal_capi"; | ||
| 71 | + ++ pkgs.lib.optional (withTemporal && useSharedTemporal) "--shared-temporal_capi" | ||
| 72 | + ++ pkgs.lib.optional withPerfetto "--with-perfetto"; | ||
| 71 | 73 | in | |
| 72 | 74 | pkgs.mkShell { | |
| 73 | 75 | inherit nativeBuildInputs; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -44,6 +44,9 @@ let | |||
| 44 | 44 | ../../tools/v8_gypfiles/toolchain.gypi | |
| 45 | 45 | ../../tools/v8_gypfiles/v8.gyp | |
| 46 | 46 | ] | |
| 47 | + ++ lib.optionals (builtins.elem "--with-perfetto" configureFlags) [ | ||
| 48 | + ../../deps/perfetto | ||
| 49 | + ] | ||
| 47 | 50 | ++ lib.optionals (icu != null) [ | |
| 48 | 51 | ../../tools/icu/icu_versions.json | |
| 49 | 52 | ../../tools/icu/icu-system.gyp | |
0 commit comments