src: add perfetto trace agent by legendecas · Pull Request #64565 · nodejs/node · GitHub

This implements the Perfetto tracing support. The support is enabled with configure flag --with-perfetto.

A perfetto trace is written to files like node_trace.1.pftrace (protobuf encoded) by default, when the trace is enabled. Trace files can be viewed on https://ui.perfetto.dev/. JSON output is intentionally not supported.

As of this PR, when perfetto is enabled, inspector trace support is disabled. Supporting perfetto in inspector would need change to the inspector protocol to deliver raw bytes directly, instead of protocol object values.

Refs: nodejs/diagnostics#654

Review requested:

@nodejs/config
@nodejs/gyp
@nodejs/inspector
@nodejs/cpp-reviewers
@nodejs/diagnostics

Codecov Report

❌ Patch coverage is 83.76068% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (4bec191) to head (df7e4de).
⚠️ Report is 41 commits behind head on main.

Files with missing lines	Patch %	Lines
src/tracing/trace_event_legacy_inl.h	78.33%	16 Missing and 10 partials ⚠️
lib/internal/trace_events.js	91.07%	5 Missing ⚠️
src/node_dir.cc	54.54%	0 Missing and 5 partials ⚠️
src/tracing/agent.h	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #64565   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files         741      743    +2     
  Lines      242106   242168   +62     
  Branches    45551    45595   +44     
=======================================
+ Hits       218211   218276   +65     
+ Misses      15430    15404   -26     
- Partials     8465     8488   +23

Files with missing lines	Coverage Δ
lib/internal/console/constructor.js	98.18% <100.00%> (-0.01%)	⬇️
lib/internal/constants.js	98.27% <100.00%> (+0.06%)	⬆️
lib/internal/http.js	92.33% <100.00%> (+0.05%)	⬆️
lib/internal/trace_events_async_hooks.js	93.81% <100.00%> (-0.13%)	⬇️
lib/internal/util/debuglog.js	95.32% <100.00%> (+0.01%)	⬆️
src/inspector_agent.cc	80.52% <ø> (ø)
src/node_constants.cc	99.71% <ø> (-0.01%)	⬇️
src/node_file.cc	74.23% <ø> (ø)
src/node_internals.h	80.35% <ø> (ø)
src/node_options.h	97.51% <ø> (-0.50%)	⬇️
... and 11 more

... and 51 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CI failure is related to #64633.

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>

CI: https://ci.nodejs.org/job/node-test-pull-request/75016/

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64721 Fixes: nodejs/diagnostics#654 Refs: #64565 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64565 Refs: nodejs/diagnostics#654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64721 Fixes: nodejs/diagnostics#654 Refs: #64565 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: build: * (SEMVER-MINOR) perfetto-sdk (Chengzhong Wu) #64565 crypto: * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949 * update root certificates to NSS 3.125 (Node.js GitHub Bot) #64746 doc: * (SEMVER-MINOR) formalize fn/name as part of TestOptions API (Christopher Hiller) #64946 lib: * (SEMVER-MINOR) add perfetto support (Chengzhong Wu) #64565 module: * (SEMVER-MINOR) implement Symbol.dispose in ModuleHooks (Remco Haszing) #63928 net: * (SEMVER-MINOR) add experimental net/promises API (Ethan Arrowood) #63965 src: * (SEMVER-MINOR) add perfetto trace agent (Chengzhong Wu) #64565 * (SEMVER-MINOR) rename legacy trace event headers (Chengzhong Wu) #64565 * (SEMVER-MINOR) fix trace macro compatibility (Chengzhong Wu) #64565 test_runner: * (SEMVER-MINOR) add support for --test-coverage-include-all (avivkeller) #64830 PR-URL: #65027

Notable changes: crypto: * (SEMVER-MINOR) support loading private keys through STORE loaders (Filip Skokan) #63949 * update root certificates to NSS 3.125 (Node.js GitHub Bot) #64746 lib: * (SEMVER-MINOR) add perfetto support (Chengzhong Wu) #64565 module: * (SEMVER-MINOR) implement `Symbol.dispose` in ModuleHooks (Remco Haszing) #63928 net: * (SEMVER-MINOR) add experimental `node:net/promises` API (Ethan Arrowood) #63965 test_runner: * (SEMVER-MINOR) add support for `--test-coverage-include-all` (avivkeller) #64830 PR-URL: #65027

Backport Node's Perfetto tracing agent now that Chromium V8 no longer exposes the legacy tracing controller APIs. Ref: nodejs/node#64565 Ref: nodejs/node#64721 Co-Authored-By: GitHub Copilot <copilot@github.com>

Ref: nodejs/node#64565 Co-Authored-By: GitHub Copilot <copilot@github.com>

Backport Node's Perfetto tracing agent now that Chromium V8 no longer exposes the legacy tracing controller APIs. Ref: nodejs/node#64565 Ref: nodejs/node#64721 Co-Authored-By: GitHub Copilot <copilot@github.com>

Ref: nodejs/node#64565 Co-Authored-By: GitHub Copilot <copilot@github.com>

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64721 Fixes: nodejs/diagnostics#654 Refs: #64565 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 17, 2026

legendecas force-pushed the perfetto-build-sdk branch from 8213a32 to 5745cc2 Compare July 17, 2026 19:59

legendecas added trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency. labels Jul 17, 2026

legendecas force-pushed the perfetto-build-sdk branch 6 times, most recently from 7c5702c to edae450 Compare July 17, 2026 21:00

legendecas force-pushed the perfetto-build-sdk branch 2 times, most recently from 450a910 to ada6a01 Compare July 20, 2026 18:33

legendecas added 5 commits July 21, 2026 09:12

build: perfetto-sdk

126783a

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>

lib: add perfetto support

ea1f7da

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>

src: fix trace macro compatibility

eba6f9f

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>

src: rename legacy trace event headers

1271bd3

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>

src: add perfetto trace agent

340d065

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>

legendecas force-pushed the perfetto-build-sdk branch from ada6a01 to 340d065 Compare July 21, 2026 13:13

jasnell reviewed Jul 22, 2026

View reviewed changes

Comment thread src/tracing/agent_perfetto.cc Outdated

jasnell reviewed Jul 22, 2026

View reviewed changes

Comment thread src/tracing/agent_perfetto.h Outdated

jasnell approved these changes Jul 22, 2026

View reviewed changes

legendecas added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jul 22, 2026

fixup! src: add perfetto trace agent

df7e4de

aduh95 pushed a commit that referenced this pull request Aug 4, 2026

build: perfetto-sdk

df608e0

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64565 Refs: nodejs/diagnostics#654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>

aduh95 pushed a commit that referenced this pull request Aug 4, 2026

lib: add perfetto support

c1e4f73

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64565 Refs: nodejs/diagnostics#654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>

github-actions Bot mentioned this pull request Aug 4, 2026

2026-08-05, Version 26.7.0 (Current) #65027

Merged

ckerr added a commit to electron/electron that referenced this pull request Aug 4, 2026

node#64565: src: rename legacy trace event headers

c8ff7da

Ref: nodejs/node#64565 Co-Authored-By: GitHub Copilot <copilot@github.com>

ckerr added a commit to electron/electron that referenced this pull request Aug 4, 2026

fix(patch): add perfetto trace agent

8c8193d

Ref: nodejs/node#64565 Co-Authored-By: GitHub Copilot <copilot@github.com>

ckerr added a commit to electron/electron that referenced this pull request Aug 4, 2026

fix(patch): add perfetto trace agent

d41b91f

Ref: nodejs/node#64565 Co-Authored-By: GitHub Copilot <copilot@github.com>

ckerr added a commit to electron/electron that referenced this pull request Aug 5, 2026

node#64565: src: rename legacy trace event headers

9be8433

Ref: nodejs/node#64565 Co-Authored-By: GitHub Copilot <copilot@github.com>

ckerr added a commit to electron/electron that referenced this pull request Aug 5, 2026

fix(patch): add perfetto trace agent

7b3b478

Ref: nodejs/node#64565 Co-Authored-By: GitHub Copilot <copilot@github.com>

ckerr added a commit to electron/electron that referenced this pull request Aug 5, 2026

fix(patch): add perfetto trace agent

8bcd5ea

Ref: nodejs/node#64565 Co-Authored-By: GitHub Copilot <copilot@github.com>

ckerr added a commit to electron/electron that referenced this pull request Aug 5, 2026

fix(patch): own fallback tracing controller

d274c59

Ref: nodejs/node#64565 Co-Authored-By: GitHub Copilot <copilot@github.com>

AugustinMauroy mentioned this pull request Aug 5, 2026

doc(cli-flag): missing perfetto #65055

Closed

lazerg mentioned this pull request Aug 5, 2026

doc: document the --with-perfetto build flag #65056

Closed

ghappforreleaseplease Bot mentioned this pull request Aug 10, 2026

chore(mise): upgrade local tools jylenhof/mise-update-tool#28

Closed

src: add perfetto trace agent by legendecas · Pull Request #64565 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: add perfetto trace agent - #64565

src: add perfetto trace agent#64565
legendecas wants to merge 6 commits into
nodejs:mainfrom
legendecas:perfetto-build-sdk

legendecas commented Jul 17, 2026 •
edited
Loading

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 17, 2026 •
edited by legendecas
Loading

Uh oh!

Uh oh!

codecov Bot commented Jul 17, 2026 •
edited
Loading

Uh oh!

Uh oh!

legendecas commented Jul 20, 2026

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

src: add perfetto trace agent by legendecas · Pull Request #64565 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: add perfetto trace agent - #64565

src: add perfetto trace agent#64565legendecas wants to merge 6 commits intonodejs:mainnodejs/node:mainfrom legendecas:perfetto-build-sdklegendecas/node:perfetto-build-sdkCopy head branch name to clipboard

Conversation

legendecas commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 17, 2026 • edited by legendecas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

legendecas commented Jul 20, 2026

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

src: add perfetto trace agent#64565
legendecas wants to merge 6 commits into
nodejs:mainfrom
legendecas:perfetto-build-sdk

legendecas commented Jul 17, 2026 •
edited
Loading

nodejs-github-bot commented Jul 17, 2026 •
edited by legendecas
Loading

codecov Bot commented Jul 17, 2026 •
edited
Loading