Commit 573cafe
test: remove eslint-disable comments from fixtures
We do not lint the fixtures code so eslint-disable comments are
superfluous.
PR-URL: #41859
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent f8acca8 commit 573cafe
7 files changed
Lines changed: 0 additions & 8 deletions
File tree
- test/fixtures
- es-module-loaders
- es-modules
- wpt/streams
- readable-streams
- resources
- transform-streams
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,4 +1,3 @@ | |||
| 1 | - /* eslint-disable node-core/required-modules */ | ||
| 2 | 1 | export async function resolve(specifier, { parentURL, importAssertions }, defaultResolve) { | |
| 3 | 2 | if (parentURL && specifier === '../fixtures/es-modules/test-esm-ok.mjs') { | |
| 4 | 3 | return { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,4 +1,3 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | - /* eslint-disable node-core/required-modules */ | ||
| 3 | 2 | ||
| 4 | 3 | throw undefined; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,2 +1 @@ | |||
| 1 | - /* eslint-disable no-unused-vars */ | ||
| 2 | 1 | import { ofLife } from '../experimental.json' assert { type: 'json' }; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -630,7 +630,6 @@ promise_test(() => { | |||
| 630 | 630 | let pullCalled = 0; | |
| 631 | 631 | let cancelCalled = 0; | |
| 632 | 632 | ||
| 633 | - /* eslint-disable no-use-before-define */ | ||
| 634 | 633 | class Source { | |
| 635 | 634 | start(c) { | |
| 636 | 635 | startCalled++; | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -22,7 +22,6 @@ test(t => { | |||
| 22 | 22 | ||
| 23 | 23 | const trappedProperties = ['highWaterMark', 'size', 'start', 'type', 'mode']; | |
| 24 | 24 | for (const property of trappedProperties) { | |
| 25 | - // eslint-disable-next-line no-extend-native, accessor-pairs | ||
| 26 | 25 | Object.defineProperty(Object.prototype, property, { | |
| 27 | 26 | get() { throw new Error(`${property} getter called`); }, | |
| 28 | 27 | configurable: true | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -57,7 +57,6 @@ self.garbageCollect = () => { | |||
| 57 | 57 | // Present in some WebKit development environments | |
| 58 | 58 | GCController.collect(); | |
| 59 | 59 | } else { | |
| 60 | - /* eslint-disable no-console */ | ||
| 61 | 60 | console.warn('Tests are running without the ability to do manual garbage collection. They will still work, but ' + | |
| 62 | 61 | 'coverage will be suboptimal.'); | |
| 63 | 62 | /* eslint-enable no-console */ | |
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,13 +5,11 @@ | |||
| 5 | 5 | // interfering with other tests. | |
| 6 | 6 | ||
| 7 | 7 | test(t => { | |
| 8 | - // eslint-disable-next-line no-extend-native, accessor-pairs | ||
| 9 | 8 | Object.defineProperty(Object.prototype, 'highWaterMark', { | |
| 10 | 9 | set() { throw new Error('highWaterMark setter called'); }, | |
| 11 | 10 | configurable: true | |
| 12 | 11 | }); | |
| 13 | 12 | ||
| 14 | - // eslint-disable-next-line no-extend-native, accessor-pairs | ||
| 15 | 13 | Object.defineProperty(Object.prototype, 'size', { | |
| 16 | 14 | set() { throw new Error('size setter called'); }, | |
| 17 | 15 | configurable: true | |
0 commit comments