FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove eslint-disable comments from fixtures by Trott · Pull Request #41859 · nodejs/node · GitHub

/ node Public

test: remove eslint-disable comments from fixtures - #41859

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:fixtures-eslint
Feb 6, 2022
Merged

test: remove eslint-disable comments from fixtures#41859
Trott merged 1 commit into
nodejs:masterfrom
Trott:fixtures-eslint

Conversation

Trott commented Feb 5, 2022

Copy link
Copy Markdown
Member

We do not lint the fixtures code so eslint-disable comments are
superfluous.

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 5, 2022
Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 5, 2022

github-actions Bot commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2022

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: nodejs#41859
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott merged commit fa05f80 into nodejs:master Feb 6, 2022

Trott commented Feb 6, 2022

Copy link
Copy Markdown
Member Author

Landed in fa05f80

Trott deleted the fixtures-eslint branch February 6, 2022 16:27
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: nodejs#41859
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL