FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update ada to 2.6.8 · nodejs/node@597ea77 · GitHub

/ node Public

Commit 597ea77

Browse files
nodejs-github-bot
authored and
targos
committed
deps: update ada to 2.6.8
PR-URL: #49340 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 8e7dcba commit 597ea77

3 files changed

Lines changed: 19 additions & 17 deletions

File tree

‎deps/ada/ada.cpp‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* auto-generated on 2023-09-05 16:55:45 -0400. Do not edit! */
1+
/* auto-generated on 2023-09-19 16:48:25 -0400. Do not edit! */
22
/* begin file src/ada.cpp */
33
#include "ada.h"
44
/* begin file src/checkers.cpp */
@@ -11864,7 +11864,7 @@ bool url::set_host_or_hostname(const std::string_view input) {
1186411864
}
1186511865

1186611866
// Let host be the result of host parsing host_view with url is not special.
11867-
if (host_view.empty()) {
11867+
if (host_view.empty() && !is_special()) {
1186811868
host = "";
1186911869
return true;
1187011870
}
@@ -13625,13 +13625,12 @@ bool url_aggregator::set_host_or_hostname(const std::string_view input) {
1362513625
// empty string, and either url includes credentials or url's port is
1362613626
// non-null, return.
1362713627
else if (host_view.empty() &&
13628-
(is_special() || has_credentials() ||
13629-
components.port != url_components::omitted)) {
13628+
(is_special() || has_credentials() || has_port())) {
1363013629
return false;
1363113630
}
1363213631

1363313632
// Let host be the result of host parsing host_view with url is not special.
13634-
if (host_view.empty()) {
13633+
if (host_view.empty() && !is_special()) {
1363513634
if (has_hostname()) {
1363613635
clear_hostname(); // easy!
1363713636
} else if (has_dash_dot()) {

‎deps/ada/ada.h‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* auto-generated on 2023-09-05 16:55:45 -0400. Do not edit! */
1+
/* auto-generated on 2023-09-19 16:48:25 -0400. Do not edit! */
22
/* begin file include/ada.h */
33
/**
44
* @file ada.h
@@ -1055,9 +1055,10 @@ inline constexpr bool is_normalized_windows_drive_letter(
10551055
return input.size() >= 2 && (is_alpha(input[0]) && (input[1] == ':'));
10561056
}
10571057

1058-
ada_really_inline constexpr bool begins_with(std::string_view view,
1059-
std::string_view prefix) {
1058+
ada_really_inline bool begins_with(std::string_view view,
1059+
std::string_view prefix) {
10601060
// in C++20, you have view.begins_with(prefix)
1061+
// std::equal is constexpr in C++20
10611062
return view.size() >= prefix.size() &&
10621063
std::equal(prefix.begin(), prefix.end(), view.begin());
10631064
}
@@ -5020,10 +5021,10 @@ inline constexpr bool is_normalized_windows_drive_letter(
50205021
std::string_view input) noexcept;
50215022

50225023
/**
5023-
* @warning Will be removed when Ada supports C++20.
5024+
* @warning Will be removed when Ada requires C++20.
50245025
*/
5025-
ada_really_inline constexpr bool begins_with(std::string_view view,
5026-
std::string_view prefix);
5026+
ada_really_inline bool begins_with(std::string_view view,
5027+
std::string_view prefix);
50275028

50285029
/**
50295030
* Returns true if an input is an ipv4 address.
@@ -6557,7 +6558,9 @@ inline bool url_aggregator::has_hostname() const noexcept {
65576558

65586559
inline bool url_aggregator::has_port() const noexcept {
65596560
ada_log("url_aggregator::has_port");
6560-
return components.pathname_start != components.host_end;
6561+
// A URL cannot have a username/password/port if its host is null or the empty
6562+
// string, or its scheme is "file".
6563+
return has_hostname() && components.pathname_start != components.host_end;
65616564
}
65626565

65636566
inline bool url_aggregator::has_dash_dot() const noexcept {
@@ -6926,14 +6929,14 @@ inline void url_search_params::sort() {
69266929
#ifndef ADA_ADA_VERSION_H
69276930
#define ADA_ADA_VERSION_H
69286931

6929-
#define ADA_VERSION "2.6.7"
6932+
#define ADA_VERSION "2.6.8"
69306933

69316934
namespace ada {
69326935

69336936
enum {
69346937
ADA_VERSION_MAJOR = 2,
69356938
ADA_VERSION_MINOR = 6,
6936-
ADA_VERSION_REVISION = 7,
6939+
ADA_VERSION_REVISION = 8,
69376940
};
69386941

69396942
} // namespace ada

‎doc/contributing/maintaining/maintaining-dependencies.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ All dependencies are located within the `deps` directory.
99
This a list of all the dependencies:
1010

1111
* [acorn][]
12-
* [ada 2.6.7][]
12+
* [ada 2.6.8][]
1313
* [base64][]
1414
* [brotli][]
1515
* [c-ares][]
@@ -148,7 +148,7 @@ The [acorn](https://github.com/acornjs/acorn) dependency is a JavaScript parser.
148148
[acorn-walk](https://github.com/acornjs/acorn/tree/master/acorn-walk) is
149149
an abstract syntax tree walker for the ESTree format.
150150

151-
### ada 2.6.7
151+
### ada 2.6.8
152152

153153
The [ada](https://github.com/ada-url/ada) dependency is a
154154
fast and spec-compliant URL parser written in C++.
@@ -312,7 +312,7 @@ it comes from the Chromium team's zlib fork which incorporated
312312
performance improvements not currently available in standard zlib.
313313

314314
[acorn]: #acorn
315-
[ada 2.6.7]: #ada-267
315+
[ada 2.6.8]: #ada-268
316316
[base64]: #base64
317317
[brotli]: #brotli
318318
[c-ares]: #c-ares

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL