FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update ada to 2.6.9 by nodejs-github-bot · Pull Request #49340 · nodejs/node · GitHub

/ node Public

deps: update ada to 2.6.9 - #49340

Closed
nodejs-github-bot wants to merge 5 commits into
mainfrom
actions/tools-update-ada
ConversationCommits (5)ChecksFiles changed
Closed

deps: update ada to 2.6.9#49340
nodejs-github-bot wants to merge 5 commits into
mainfrom
actions/tools-update-ada

Conversation

nodejs-github-bot commented Aug 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 2.6.9.

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Aug 27, 2023

nodejs-github-bot commented Aug 27, 2023 •
edited by anonrig
Loading

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/url

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 27, 2023
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2023

nodejs-github-bot commented Aug 27, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53573/

nodejs-github-bot commented Aug 27, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53574/

github-actions Bot mentioned this pull request Aug 28, 2023
Open
25 tasks

nodejs-github-bot commented Aug 28, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53586/

nodejs-github-bot commented Aug 28, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53597/

github-actions Bot mentioned this pull request Aug 29, 2023
Open
21 tasks

nodejs-github-bot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53602/

nodejs-github-bot commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53607/

This was referenced Aug 30, 2023
Open
Open

nodejs-github-bot commented Aug 31, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53665/

This was referenced Sep 1, 2023
Open
Open

nodejs-github-bot commented Sep 2, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53692/

github-actions Bot mentioned this pull request Sep 3, 2023
Open
21 tasks
nodejs-github-bot changed the title deps: update ada to 2.6.3 deps: update ada to 2.6.5 Sep 3, 2023
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2023

nodejs-github-bot commented Sep 3, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53704/

anonrig commented Sep 3, 2023

Copy link
Copy Markdown
Member

@lemire the build fails with the following error

09:53:36 ../deps/ada/ada.cpp: In function 'constexpr bool ada::idna::begins_with(std::string_view, std::string_view)':
09:53:36 ../deps/ada/ada.cpp:9520:20: error: call to non-'constexpr' function 'bool std::equal(_II1, _II1, _II2) [with _II1 = const char*; _II2 = const char*]'
09:53:36    return std::equal(prefix.begin(), prefix.end(), view.begin());
09:53:36

targos pushed a commit that referenced this pull request Oct 28, 2023
deps: update ada to 2.6.8
597ea77 
PR-URL: #49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Oct 28, 2023
deps: update ada to 2.6.9
76c5f40 
PR-URL: #49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
deps: update ada to 2.6.3
2ca867f 
PR-URL: #49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
deps: update ada to 2.6.5
31a4e97 
PR-URL: #49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
deps: update ada to 2.6.7
759cf5a 
PR-URL: #49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
deps: update ada to 2.6.8
4c740b1 
PR-URL: #49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
deps: update ada to 2.6.9
03654b4 
PR-URL: #49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Nov 12, 2023
Merged
targos mentioned this pull request Nov 28, 2023
Merged
juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
deps: update ada to 2.6.3
b4c1eb5 
PR-URL: nodejs#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
deps: update ada to 2.6.5
b8dc496 
PR-URL: nodejs#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
deps: update ada to 2.6.7
8062d42 
PR-URL: nodejs#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
deps: update ada to 2.6.8
7897fbe 
PR-URL: nodejs#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
deps: update ada to 2.6.9
3a5172e 
PR-URL: nodejs#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
deps: update ada to 2.6.3
c6f59f6 
PR-URL: nodejs/node#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
deps: update ada to 2.6.5
701e100 
PR-URL: nodejs/node#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
deps: update ada to 2.6.7
193be51 
PR-URL: nodejs/node#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
deps: update ada to 2.6.8
8be7999 
PR-URL: nodejs/node#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
deps: update ada to 2.6.9
643e79a 
PR-URL: nodejs/node#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
deps: update ada to 2.6.3
71f9164 
PR-URL: nodejs/node#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
deps: update ada to 2.6.5
b2c3719 
PR-URL: nodejs/node#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
deps: update ada to 2.6.7
58f8a7f 
PR-URL: nodejs/node#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
deps: update ada to 2.6.8
6a3bde7 
PR-URL: nodejs/node#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
deps: update ada to 2.6.9
f0f77c1 
PR-URL: nodejs/node#49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
UlisesGascon UlisesGascon approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL