Commit 5f08bfe
tools: don't gitignore base64 config.h
The file is checked into git. Ignoring it causes a very non-obvious way
of breaking tarball builds:
1. Download and unpack tarball
2. Check the sources into git with `git init; git add .; git commit -a`
3. Clean the source tree with `git clean -dfx`
4. Run `./configure && make`
5. Observe build failure because config.h is missing
Fixes: #47638
PR-URL: #48174
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>1 parent ded0e2d commit 5f08bfe
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -62,7 +62,11 @@ mv "$WORKSPACE/base64" "$DEPS_DIR/base64/" | |||
| 62 | 62 | ||
| 63 | 63 | # Build configuration is handled by `deps/base64/base64.gyp`, but since `config.h` has to be present for the build | |
| 64 | 64 | # to work, we create it and leave it empty. | |
| 65 | - echo "// Intentionally empty" >> "$DEPS_DIR/base64/base64/lib/config.h" | ||
| 65 | + echo "// Intentionally empty" > "$DEPS_DIR/base64/base64/lib/config.h" | ||
| 66 | + | ||
| 67 | + # Clear out .gitignore, otherwise config.h is ignored. That's dangerous when | ||
| 68 | + # people check in our tarballs into source control and run `git clean`. | ||
| 69 | + echo "# Intentionally empty" > "$DEPS_DIR/base64/base64/.gitignore" | ||
| 66 | 70 | ||
| 67 | 71 | # update the base64_version.h | |
| 68 | 72 | cat > "$BASE_DIR/src/base64_version.h" << EOL | |
0 commit comments