tools: don't gitignore base64 config.h - #48174
Merged
nodejs-github-bot merged 1 commit intoMay 30, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
reviewed
May 25, 2023
Comment thread
deps/base64/base64/.gitignore
Outdated
targos
reviewed
May 25, 2023
Comment thread
tools/dep_updaters/update-base64.sh
Outdated
targos
approved these changes
May 25, 2023
richardlau
approved these changes
May 25, 2023
marco-ippolito
approved these changes
May 25, 2023
lpinca
reviewed
May 25, 2023
Comment thread
tools/dep_updaters/update-base64.sh
Outdated
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: nodejs#47638
lpinca
approved these changes
May 26, 2023
anonrig
approved these changes
May 26, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced May 28, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
23 tasks
This was referenced May 31, 2023
targos
pushed a commit
that referenced
this pull request
Jun 4, 2023
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: #47638 PR-URL: #48174 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
30 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: #47638 PR-URL: #48174 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: nodejs#47638 PR-URL: nodejs#48174 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: nodejs#47638 PR-URL: nodejs#48174 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: nodejs#47638 PR-URL: nodejs#48174 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds:
Fixes: #47638