fs: avoid computing time coefficient constants in runtime · nodejs/node@62b5879 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 62b5879

Browse filesBrowse the repository at this point in the historyBrowse files

LiviaMedeiros

authored and

RafaelGSS

committed

fs: avoid computing time coefficient constants in runtime

PR-URL: #58728 Fixes: #58726 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

1 parent f125310 commit 62b5879
Copy full SHA for 62b5879

1 file changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/fs
  • utils.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/fs/utils.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/utils.js

+4-4Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -419,10 +419,10 @@ StatsBase.prototype.isSocket = function() {
419	419	return this._checkModeProperty(S_IFSOCK);
420	420	};
421	421
422		- const kNsPerMsBigInt = 10n ** 6n;
423		- const kNsPerSecBigInt = 10n ** 9n;
424		- const kMsPerSec = 10 ** 3;
425		- const kNsPerMs = 10 ** 6;
	422	+ const kNsPerMsBigInt = 1_000_000n;
	423	+ const kNsPerSecBigInt = 1_000_000_000n;
	424	+ const kMsPerSec = 1_000;
	425	+ const kNsPerMs = 1_000_000;
426	426	function msFromTimeSpec(sec, nsec) {
427	427	return sec * kMsPerSec + nsec / kNsPerMs;
428	428	}

0 commit comments

Comments

0 (0)