FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: avoid computing time coefficient constants in runtime by LiviaMedeiros · Pull Request #58728 · nodejs/node · GitHub

/ node Public

fs: avoid computing time coefficient constants in runtime - #58728

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:fs-coefficient-no-runtime-pow
Jun 18, 2025
ConversationCommits (1)ChecksFiles changed
Merged

fs: avoid computing time coefficient constants in runtime#58728
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:fs-coefficient-no-runtime-pow

Conversation

LiviaMedeiros commented Jun 16, 2025

Copy link
Copy Markdown
Member

Fixes: #58726 1

These constants can be precomputed.

Footnotes

  1. even though it's not a Node.js bug ↩

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 16, 2025

codecov Bot commented Jun 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (d6dade5) to head (12f5b70).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58728   +/-   ##
=======================================
  Coverage   90.12%   90.13%           
=======================================
  Files         637      637           
  Lines      188121   188121           
  Branches    36892    36891    -1     
=======================================
+ Hits       169552   169557    +5     
+ Misses      11313    11311    -2     
+ Partials     7256     7253    -3
Files with missing lines Coverage Δ
lib/internal/fs/utils.js 99.69% <100.00%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LiviaMedeiros mentioned this pull request Jun 16, 2025
Closed
LiviaMedeiros added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 16, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2025

nodejs-github-bot commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67487/

juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 18, 2025
nodejs-github-bot merged commit f2e99c5 into nodejs:main Jun 18, 2025

nodejs-github-bot commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

Landed in f2e99c5

RafaelGSS pushed a commit that referenced this pull request Jun 23, 2025
fs: avoid computing time coefficient constants in runtime
62b5879 
PR-URL: #58728
Fixes: #58726
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This was referenced Jun 23, 2025
Closed
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
fs: avoid computing time coefficient constants in runtime
ff4499c 
PR-URL: #58728
Fixes: #58726
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
fs: avoid computing time coefficient constants in runtime
dedd9d1 
PR-URL: #58728
Fixes: #58726
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
github-actions Bot mentioned this pull request Jul 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
Ethan-Arrowood Ethan-Arrowood approved these changes
juanarbol juanarbol approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs: non-bigint stat can give 0.20566138856% bigger results

6 participants

Back | FazBrowse Home | New Git URL