Commit 6993386
sqlite: reserve vectors space
PR-URL: #61540
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>1 parent f16b532 commit 6993386
1 file changed
Lines changed: 12 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -322,6 +322,8 @@ class CustomAggregate { | |||
| 322 | 322 | ||
| 323 | 323 | auto recv = Undefined(isolate); | |
| 324 | 324 | LocalVector<Value> js_argv(isolate); | |
| 325 | + js_argv.reserve(argc + 1); | ||
| 326 | + | ||
| 325 | 327 | js_argv.emplace_back(Local<Value>::New(isolate, agg->value)); | |
| 326 | 328 | ||
| 327 | 329 | for (int i = 0; i < argc; ++i) { | |
@@ -625,6 +627,7 @@ void UserDefinedFunction::xFunc(sqlite3_context* ctx, | |||
| 625 | 627 | auto recv = Undefined(isolate); | |
| 626 | 628 | auto fn = self->fn_.Get(isolate); | |
| 627 | 629 | LocalVector<Value> js_argv(isolate); | |
| 630 | + js_argv.reserve(argc); | ||
| 628 | 631 | ||
| 629 | 632 | for (int i = 0; i < argc; ++i) { | |
| 630 | 633 | sqlite3_value* value = argv[i]; | |
@@ -2063,18 +2066,16 @@ int DatabaseSync::AuthorizerCallback(void* user_data, | |||
| 2063 | 2066 | CHECK(cb->IsFunction()); | |
| 2064 | 2067 | ||
| 2065 | 2068 | Local<Function> callback = cb.As<Function>(); | |
| 2066 | - LocalVector<Value> js_argv(isolate); | ||
| 2067 | 2069 | ||
| 2068 | - // Convert SQLite authorizer parameters to JavaScript values | ||
| 2069 | - js_argv.emplace_back(Integer::New(isolate, action_code)); | ||
| 2070 | - js_argv.emplace_back( | ||
| 2071 | - NullableSQLiteStringToValue(isolate, param1).ToLocalChecked()); | ||
| 2072 | - js_argv.emplace_back( | ||
| 2073 | - NullableSQLiteStringToValue(isolate, param2).ToLocalChecked()); | ||
| 2074 | - js_argv.emplace_back( | ||
| 2075 | - NullableSQLiteStringToValue(isolate, param3).ToLocalChecked()); | ||
| 2076 | - js_argv.emplace_back( | ||
| 2077 | - NullableSQLiteStringToValue(isolate, param4).ToLocalChecked()); | ||
| 2070 | + LocalVector<Value> js_argv( | ||
| 2071 | + isolate, | ||
| 2072 | + { | ||
| 2073 | + Integer::New(isolate, action_code), | ||
| 2074 | + NullableSQLiteStringToValue(isolate, param1).ToLocalChecked(), | ||
| 2075 | + NullableSQLiteStringToValue(isolate, param2).ToLocalChecked(), | ||
| 2076 | + NullableSQLiteStringToValue(isolate, param3).ToLocalChecked(), | ||
| 2077 | + NullableSQLiteStringToValue(isolate, param4).ToLocalChecked(), | ||
| 2078 | + }); | ||
| 2078 | 2079 | ||
| 2079 | 2080 | MaybeLocal<Value> retval = callback->Call( | |
| 2080 | 2081 | context, Undefined(isolate), js_argv.size(), js_argv.data()); | |
0 commit comments