FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

sqlite: reserve local vectors space by araujogui · Pull Request #61540 · nodejs/node · GitHub

/ node Public

sqlite: reserve local vectors space - #61540

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
araujogui:sqlite/reserve-vectors
Jan 29, 2026
ConversationCommits (2)ChecksFiles changed
Merged

sqlite: reserve local vectors space#61540
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
araujogui:sqlite/reserve-vectors

Conversation

araujogui commented Jan 27, 2026

Copy link
Copy Markdown
Member

Reserve local vectors to prevent reallocations

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 27, 2026

codecov Bot commented Jan 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.78%. Comparing base (8fd5f6b) to head (ec4defd).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61540      +/-   ##
==========================================
- Coverage   89.79%   89.78%   -0.01%     
==========================================
  Files         672      672              
  Lines      203756   203756              
  Branches    39169    39166       -3     
==========================================
- Hits       182956   182937      -19     
- Misses      13135    13159      +24     
+ Partials     7665     7660       -5
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.66% <100.00%> (ø)

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334 approved these changes Jan 27, 2026
View reviewed changes
Comment thread src/node_sqlite.cc Outdated
geeksilva97 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 27, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71072/

araujogui force-pushed the sqlite/reserve-vectors branch from af35d93 to ec4defd Compare January 27, 2026 20:32
addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2026

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71109/

Renegade334 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 28, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2026
nodejs-github-bot merged commit 68d7b6f into nodejs:main Jan 29, 2026
74 of 75 checks passed

nodejs-github-bot commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Landed in 68d7b6f

aduh95 pushed a commit that referenced this pull request Feb 2, 2026
sqlite: reserve vectors space
d1796c5 
PR-URL: #61540
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
sqlite: reserve vectors space
6993386 
PR-URL: #61540
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
sqlite: reserve vectors space
d5abe80 
PR-URL: #61540
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request Feb 14, 2026
sqlite: reserve vectors space
f292042 
PR-URL: #61540
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
github-actions Bot mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
sqlite: reserve vectors space
8e8f705 
PR-URL: #61540
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026
sqlite: reserve vectors space
06ce005 
PR-URL: nodejs#61540
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
Renegade334 Renegade334 approved these changes
geeksilva97 geeksilva97 approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL