Commit 708f57e
util: move util.isNumber to eol
PR-URL: #52744
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 6ec403f commit 708f57e
4 files changed
Lines changed: 5 additions & 46 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1177,6 +1177,9 @@ The `util.isNullOrUndefined()` API has been removed. Please use | |||
| 1177 | 1177 | ||
| 1178 | 1178 | <!-- YAML | |
| 1179 | 1179 | changes: | |
| 1180 | + - version: REPLACEME | ||
| 1181 | + pr-url: https://github.com/nodejs/node/pull/52744 | ||
| 1182 | + description: End-of-Life deprecation. | ||
| 1180 | 1183 | - version: v22.0.0 | |
| 1181 | 1184 | pr-url: https://github.com/nodejs/node/pull/50488 | |
| 1182 | 1185 | description: Runtime deprecation. | |
@@ -1192,9 +1195,9 @@ changes: | |||
| 1192 | 1195 | description: Documentation-only deprecation. | |
| 1193 | 1196 | --> | |
| 1194 | 1197 | ||
| 1195 | - Type: Runtime | ||
| 1198 | + Type: End-of-Life | ||
| 1196 | 1199 | ||
| 1197 | - The [`util.isNumber()`][] API is deprecated. Please use | ||
| 1200 | + The `util.isNumber()` API has been removed. Please use | ||
| 1198 | 1201 | `typeof arg === 'number'` instead. | |
| 1199 | 1202 | ||
| 1200 | 1203 | ### DEP0053: `util.isObject()` | |
@@ -3790,7 +3793,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][]. | |||
| 3790 | 3793 | [`util.isArray()`]: util.md#utilisarrayobject | |
| 3791 | 3794 | [`util.isError()`]: util.md#utiliserrorobject | |
| 3792 | 3795 | [`util.isFunction()`]: util.md#utilisfunctionobject | |
| 3793 | - [`util.isNumber()`]: util.md#utilisnumberobject | ||
| 3794 | 3796 | [`util.isObject()`]: util.md#utilisobjectobject | |
| 3795 | 3797 | [`util.isPrimitive()`]: util.md#utilisprimitiveobject | |
| 3796 | 3798 | [`util.isRegExp()`]: util.md#utilisregexpobject | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3045,33 +3045,6 @@ util.isFunction(Bar); | |||
| 3045 | 3045 | // Returns: true | |
| 3046 | 3046 | ``` | |
| 3047 | 3047 | ||
| 3048 | - ### `util.isNumber(object)` | ||
| 3049 | - | ||
| 3050 | - <!-- YAML | ||
| 3051 | - added: v0.11.5 | ||
| 3052 | - deprecated: v4.0.0 | ||
| 3053 | - --> | ||
| 3054 | - | ||
| 3055 | - > Stability: 0 - Deprecated: Use `typeof value === 'number'` instead. | ||
| 3056 | - | ||
| 3057 | - * `object` {any} | ||
| 3058 | - * Returns: {boolean} | ||
| 3059 | - | ||
| 3060 | - Returns `true` if the given `object` is a `Number`. Otherwise, returns `false`. | ||
| 3061 | - | ||
| 3062 | - ```js | ||
| 3063 | - const util = require('node:util'); | ||
| 3064 | - | ||
| 3065 | - util.isNumber(false); | ||
| 3066 | - // Returns: false | ||
| 3067 | - util.isNumber(Infinity); | ||
| 3068 | - // Returns: true | ||
| 3069 | - util.isNumber(0); | ||
| 3070 | - // Returns: true | ||
| 3071 | - util.isNumber(NaN); | ||
| 3072 | - // Returns: true | ||
| 3073 | - ``` | ||
| 3074 | - | ||
| 3075 | 3048 | ### `util.isObject(object)` | |
| 3076 | 3049 | ||
| 3077 | 3050 | <!-- YAML | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -90,15 +90,6 @@ function lazyAbortController() { | |||
| 90 | 90 | ||
| 91 | 91 | let internalDeepEqual; | |
| 92 | 92 | ||
| 93 | - /** | ||
| 94 | - * @deprecated since v4.0.0 | ||
| 95 | - * @param {any} arg | ||
| 96 | - * @returns {arg is number} | ||
| 97 | - */ | ||
| 98 | - function isNumber(arg) { | ||
| 99 | - return typeof arg === 'number'; | ||
| 100 | - } | ||
| 101 | - | ||
| 102 | 93 | /** | |
| 103 | 94 | * @param {any} arg | |
| 104 | 95 | * @returns {arg is string} | |
@@ -398,9 +389,6 @@ module.exports = { | |||
| 398 | 389 | } | |
| 399 | 390 | return internalDeepEqual(a, b); | |
| 400 | 391 | }, | |
| 401 | - isNumber: deprecate(isNumber, | ||
| 402 | - 'The `util.isNumber` API is deprecated. Please use `typeof arg === "number"` instead.', | ||
| 403 | - 'DEP0052'), | ||
| 404 | 392 | isString: deprecate(isString, | |
| 405 | 393 | 'The `util.isString` API is deprecated. Please use `typeof arg === "string"` instead.', | |
| 406 | 394 | 'DEP0056'), | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -103,10 +103,6 @@ assert.strictEqual(util.isUndefined(), true); | |||
| 103 | 103 | assert.strictEqual(util.isUndefined(null), false); | |
| 104 | 104 | assert.strictEqual(util.isUndefined('string'), false); | |
| 105 | 105 | ||
| 106 | - assert.strictEqual(util.isNumber(42), true); | ||
| 107 | - assert.strictEqual(util.isNumber(), false); | ||
| 108 | - assert.strictEqual(util.isNumber('string'), false); | ||
| 109 | - | ||
| 110 | 106 | assert.strictEqual(util.isString('string'), true); | |
| 111 | 107 | assert.strictEqual(util.isString(), false); | |
| 112 | 108 | assert.strictEqual(util.isString(42), false); | |
0 commit comments