Commit 7153f96
build: unbreak -prof, disable PIE on OS X
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7")
unwittingly turned on new ASLR features that make `-prof` unusable for
profiling C++ code, breaking `test/parallel/test-tick-processor.js` in
the process. Build with `-Wl,-no_pie` for now.
Fixes: #5903
PR-URL: #6453
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 089362f commit 7153f96
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -325,7 +325,12 @@ | |||
| 325 | 325 | }, | |
| 326 | 326 | 'target_conditions': [ | |
| 327 | 327 | ['_type!="static_library"', { | |
| 328 | - 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']}, | ||
| 328 | + 'xcode_settings': { | ||
| 329 | + 'OTHER_LDFLAGS': [ | ||
| 330 | + '-Wl,-no_pie', | ||
| 331 | + '-Wl,-search_paths_first', | ||
| 332 | + ], | ||
| 333 | + }, | ||
| 329 | 334 | }], | |
| 330 | 335 | ], | |
| 331 | 336 | 'conditions': [ | |
0 commit comments