build: unbreak -prof, disable PIE on OS X - #6453
Conversation
Sorry, something went wrong.
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7") unwittingly turned on new ASLR features that make `-prof` unusable for profiling C++ code, breaking `test/parallel/test-tick-processor.js` in the process. Build with `-Wl,-no_pie` for now. Fixes: nodejs#5903
|
LGTM |
Sorry, something went wrong.
|
LGTM pending CI. Confirmed locally that it addresses the issue. |
Sorry, something went wrong.
|
CI is green! 🎉 I know we just had a conversation about not rushing PRs and stuff, but to the extent that my opinion matters, I think this one warrants expediting. Broken CI means people mistrust it even after it's fixed and then ignore additional failures, and this seems like a small and easy-to-back-out change. |
Sorry, something went wrong.
|
LGTM and go ahead if you want to land this. |
Sorry, something went wrong.
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7") unwittingly turned on new ASLR features that make `-prof` unusable for profiling C++ code, breaking `test/parallel/test-tick-processor.js` in the process. Build with `-Wl,-no_pie` for now. Fixes: #5903 PR-URL: #6453 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in a5012a0 to get back to green CI. @bnoordhuis ... I've personally had to set this for a couple of other projects. What are the particular drawbacks for leaving this on indefinitely? (sorry, not that familiar with ASLR) Should be open a tracking issue to pull this back out at a later date? |
Sorry, something went wrong.
|
@jasnell ASLR is a security feature that makes it more difficult to (for example) execute return-to-libc attacks because the address of the system() function won't be at a fixed address. I've filed #6466 for investigating how we can enable it again. |
Sorry, something went wrong.
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7") unwittingly turned on new ASLR features that make `-prof` unusable for profiling C++ code, breaking `test/parallel/test-tick-processor.js` in the process. Build with `-Wl,-no_pie` for now. Fixes: #5903 PR-URL: #6453 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7")
unwittingly turned on new ASLR features that make -prof unusable for
profiling C++ code, breaking test/parallel/test-tick-processor.js in
the process. Build with -Wl,-no_pie for now.
Fixes: #5903
CI: https://ci.nodejs.org/job/node-test-pull-request/2420/