Commit 719e33f
buffer: fix 6-byte writeUIntBE() range check
Fixes: #30420
PR-URL: #30459
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent ded0748 commit 719e33f
3 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -736,7 +736,7 @@ function writeUInt8(value, offset = 0) { | |||
| 736 | 736 | ||
| 737 | 737 | function writeUIntBE(value, offset, byteLength) { | |
| 738 | 738 | if (byteLength === 6) | |
| 739 | - return writeU_Int48BE(this, value, offset, 0, 0xffffffffffffff); | ||
| 739 | + return writeU_Int48BE(this, value, offset, 0, 0xffffffffffff); | ||
| 740 | 740 | if (byteLength === 5) | |
| 741 | 741 | return writeU_Int40BE(this, value, offset, 0, 0xffffffffff); | |
| 742 | 742 | if (byteLength === 3) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -213,7 +213,7 @@ const errorOutOfBounds = common.expectsError({ | |||
| 213 | 213 | }); | |
| 214 | 214 | ||
| 215 | 215 | // Test 1 to 6 bytes. | |
| 216 | - for (let i = 1; i < 6; i++) { | ||
| 216 | + for (let i = 1; i <= 6; i++) { | ||
| 217 | 217 | ['writeIntBE', 'writeIntLE'].forEach((fn) => { | |
| 218 | 218 | const min = -(2 ** (i * 8 - 1)); | |
| 219 | 219 | const max = 2 ** (i * 8 - 1) - 1; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -170,7 +170,7 @@ const assert = require('assert'); | |||
| 170 | 170 | }); | |
| 171 | 171 | ||
| 172 | 172 | // Test 1 to 6 bytes. | |
| 173 | - for (let i = 1; i < 6; i++) { | ||
| 173 | + for (let i = 1; i <= 6; i++) { | ||
| 174 | 174 | const range = i < 5 ? `= ${val - 1}` : ` 2 ** ${i * 8}`; | |
| 175 | 175 | const received = i > 4 ? | |
| 176 | 176 | String(val).replace(/(\d)(?=(\d\d\d)+(?!\d))/g, '$1_') : | |
0 commit comments