FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

buffer: fix 6-byte writeUIntBE() range check by mscdex · Pull Request #30459 · nodejs/node · GitHub

/ node Public

buffer: fix 6-byte writeUIntBE() range check - #30459

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:buffer-fix-writeuintbe-6
ConversationCommits (1)ChecksFiles changed
Closed

buffer: fix 6-byte writeUIntBE() range check#30459
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:buffer-fix-writeuintbe-6

Conversation

mscdex commented Nov 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #30420

CI: https://ci.nodejs.org/job/node-test-pull-request/26530/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

mscdex added the buffer Issues and PRs related to the buffer subsystem. label Nov 13, 2019

nodejs-github-bot commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26530/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 13, 2019

nodejs-github-bot commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26535/

nodejs-github-bot commented Nov 29, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27171/

nodejs-github-bot commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27195/

Trott pushed a commit that referenced this pull request Nov 30, 2019
buffer: fix 6-byte writeUIntBE() range check
c14c476 
Fixes: #30420

PR-URL: #30459
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Nov 30, 2019

Copy link
Copy Markdown
Member

Landed in c14c476

Trott closed this Nov 30, 2019
mscdex deleted the buffer-fix-writeuintbe-6 branch November 30, 2019 04:15
addaleax pushed a commit that referenced this pull request Nov 30, 2019
buffer: fix 6-byte writeUIntBE() range check
63eb4fe 
Fixes: #30420

PR-URL: #30459
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
buffer: fix 6-byte writeUIntBE() range check
f0d4392 
Fixes: #30420

PR-URL: #30459
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
buffer: fix 6-byte writeUIntBE() range check
719e33f 
Fixes: #30420

PR-URL: #30459
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs mentioned this pull request Dec 23, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+2 more reviewers
SimonSchick SimonSchick approved these changes
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

writeUIntBE() method does not throw range error for 48bit

9 participants

Back | FazBrowse Home | New Git URL