v13.3.0 proposal by BridgeAR · Pull Request #30774 · nodejs/node · GitHub

Notable Changes

fs:
- Reworked experimental recursive rmdir() (cjihrig) #30644
  - The maxBusyTries option is renamed to maxRetries, and its default is
    set to 0. The emfileWait option has been removed, and EMFILE errors
    use the same retry logic as other errors. The retryDelay option is now
    supported. ENFILE errors are now retried.
http:
- Make maximum header size configurable per-stream or per-server (Anna Henningsen) #30570
http2:
- Make maximum tolerated rejected streams configurable (Denys Otrishko) #30534
- Allow to configure maximum tolerated invalid frames (Denys Otrishko) #30534
wasi:
- Introduce initial WASI support (cjihrig) #30258

Commits

[4cd4e7c17a] - benchmark,doc,lib,test: prepare for padding lint rule (Rich Trott) #30696
[63eb4fee46] - buffer: fix 6-byte writeUIntBE() range check (Brian White) #30459
[e8af569200] - buffer: release buffers with free callbacks on env exit (Anna Henningsen) #30551
[648766bccf] - build: do not build mksnapshot and mkcodecache for --shared (Joyee Cheung) #30647
[6545314a4f] - build: add --without-node-code-cache configure option (Joyee Cheung) #30647
[80ada94cd3] - build: use Node.js instead of Node in configure (Tobias Nießen) #30642
[0aae502c67] - build,win: propagate error codes in vcbuild (João Reis) #30724
[6a53152b42] - build,win: add test-ci-native and test-ci-js (João Reis) #30724
[30a4f68a15] - child_process: document kill() return value (cjihrig) #30669
[dae36a9692] - child_process: replace var with let/const (dnlup) #30389
[4b13bca31a] - child_process: replace var with const/let in internal/child_process.js (Luis Camargo) #30414
[378c54fe97] - cluster: replace vars in child.js (EmaSuriano) #30383
[708e67a732] - cluster: replace var with let (Herrmann, Rene R. (656)) #30425
[55fbe45f69] - cluster: replace var by let in shared_handle.js (poutch) #30402
[4affc30a12] - crypto: automatically manage memory for ECDSA_SIG (Tobias Nießen) #30641
[55c2ac70b7] - crypto: remove redundant validateUint32 argument (Tobias Nießen) #30579
[0ba877a541] - deps: V8: cherry-pick 0dfd9ea51241 (bcoe) #30713
[b470354057] - deps: patch V8 to 7.9.317.25 (Myles Borins) #30679
[d257448bca] - deps: update llhttp to 2.0.1 (Fedor Indutny) #30553
[456d250d2d] - deps: V8: backport 93f189f19a03 (Michaël Zasso) #30681
[aa01ebdbca] - deps: V8: cherry-pick ca5b0ec (Anna Henningsen) #30708
[f37450f580] - dns: use length for building TXT string (Anna Henningsen) #30690
[3d302ff276] - doc: fix typographical error (Rich Trott) #30735
[19b31c1bc5] - doc: revise REPL uncaught exception text (Rich Trott) #30729
[61af1fcaa1] - doc: update signature algorithm in release doc (Myles Borins) #30673
[a8002d92ab] - doc: update README.md to fix active/maint times (Michael Dawson) #30707
[f46df0b496] - doc: update socket.bufferSize text (Rich Trott) #30723
[cbd50262c0] - doc: note that buf.buffer's contents might differ (AJ Jordan) #29651
[a25626c1ed] - doc: clarify IncomingMessage.destroy() description (Sam Foxman) #30255
[8fcb450934] - doc: fixed a typo in process.md (Harendra Singh) #30277
[ad9f737e44] - doc: documenting a bit more FreeBSD case (David Carlier) #30325
[40b762177f] - doc: add missing 'added' versions to module.builtinModules (Thomas Watson) #30562
[aca0119089] - doc: fix worker.resourceLimits indentation (Daniel Nalborczyk) #30663
[43e78578a6] - doc: fix worker.resourceLimits type (Daniel Nalborczyk) #30664
[20dbce17d5] - doc: avoid proposal syntax in code example (Alex Zherdev) #30685
[1e7c567734] - doc: address nits for src/README.md (Anna Henningsen) #30693
[87136c9bde] - doc: revise socket.connect() note (Rich Trott) #30691
[fcde49700c] - doc: remove "this API is unstable" note for v8 serdes API (bruce-one) #30631
[809a2b056b] - doc: fixup incorrect flag name reference (Guy Bedford) #30651
[3d978839c1] - doc: minor updates to releases.md (Beth Griggs) #30636
[e9f031c741] - doc: add 13 and 12 to previous versions (Andrew Hughes) #30590
[8ab18b6b6f] - doc: update AUTHORS list (Gus Caplan) #30672
[329a821d25] - doc: add explanation why keep var with for loop (Lucas Recknagel) #30380
[426ca263c8] - doc: document "Resume Build" limitation (Richard Lau) #30604
[00f7cc65a1] - doc: add note of caution about non-conforming streams (Robert Nagy) #29895
[7d98a59c39] - doc: add note about debugging worker_threads (Denys Otrishko) #30594
[8ef629a78a] - doc: simplify "is recommended" language in assert documentation (Rich Trott) #30558
[19d192d1f0] - doc: fix a typo in a date for version 13.2.0 (Kirlat) #30587
[b67759a93c] - doc,deps: document how to maintain ICU in Node.js (Steven R. Loomis) #30607
[bfcc9142f3] - doc,n-api: mark napi_detach_arraybuffer as experimental (legendecas) #30703
[365f0ab09b] - esm: data URLs should ignore unknown parameters (Bradley Farias) #30593
[0285aa0967] - events: improve performance caused by primordials (guzhizhou) #30577
[3475f9b82c] - fs: add ENFILE to rimraf retry logic (cjihrig) #30644
[f725953433] - fs: add retryDelay option to rimraf (cjihrig) #30644
[51bc379243] - fs: remove rimraf's emfileWait option (cjihrig) #30644
[612a3a2e6c] - fs: make rimraf default to 0 retries (cjihrig) #30644
[fa1f87b199] - fs: rename rimraf's maxBusyTries to maxRetries (cjihrig) #30644
[8ee27ffe77] - fs: change var to let (Àlvar Pérez) #30407
[850c2a72ea] - fs: cover fs.opendir ERR_INVALID_CALLBACK (Vladislav Botvin) #30307
[62574087ea] - (SEMVER-MINOR) http: make maximum header size configurable per-stream or per-server (Anna Henningsen) #30570
[1d1d136806] - http: set socket.server unconditionally (Anna Henningsen) #30571
[6848bfbf65] - http: replace var with let (Guilherme Goncalves) #30421
[8256d38349] - http: destructure primordials in lib/_http_server.js (Artem Maksimov) #30315
[3b169f1dbd] - http: improve performance caused by primordials (Lucas Recknagel) #30416
[6f313f9ab0] - http2: fix session memory accounting after pausing (Michael Lehenbauer) #30684
[7d37bcebea] - (SEMVER-MINOR) http2: make maximum tolerated rejected streams configurable (Denys Otrishko) #30534
[092a3c28aa] - (SEMVER-MINOR) http2: allow to configure maximum tolerated invalid frames (Denys Otrishko) #30534
[e92afd998f] - (SEMVER-MINOR) http2: replace direct array usage with struct for js_fields_ (Denys Otrishko) #30534
[30ef8e4cbd] - http2: change var to let compact.js (Maria Emmanouil) #30392
[1a2ed4a5f4] - http2: core.js replace var with let (Daniel Schuech) #30403
[f7ca7e6677] - http2: replace var with let/const (Paolo Ceschi Berrini) #30417
[6322611077] - inspector: properly shut down uv_async_t (Anna Henningsen) #30612
[de3a1c3019] - lib: enforce use of primordial Number (Sebastien Ahkrin) #30700
[5a9340d723] - lib: use static Number properties from primordials (Michaël Zasso) #30686
[892bde635e] - lib: enforce use of Boolean from primordials (Michaël Zasso) #30698
[ae2c7d0b02] - lib: replace Date.now function by primordial DateNow (Tchoupinax) #30689
[c09e3deac5] - lib: replace ArrayBuffer.isView by primordial ArrayBuffer (Vincent Dhennin) #30692
[5ef4dceb95] - lib: enforce use of Array from primordials (Michaël Zasso) #30635
[a4dfe3b7dc] - lib: flatten access to primordials (Michaël Zasso) #30610
[b545b91de5] - lib: use let instead of var (Shubham Chaturvedi) #30375
[5120926337] - lib: replace var with let/const (jens-cappelle) #30391
[b18b056d64] - lib: replace var w/ let (Chris Oyler) #30386
[3796885096] - lib: replace var with let/const (Tijl Claessens) #30390
[ffe3040659] - lib: adding perf notes js_stream_socket.js (ryan jarvinen) #30415
[797b938c49] - lib: replace var with let (Dennis Saenger) #30396
[0b64e45e41] - lib: main_thread_only change var to let (matijagaspar) #30398
[d024630f44] - lib: change var to let in stream_base_commons (Kyriakos Markakis) #30426
[3c041edbe7] - lib: use let instead of var (Semir Ajruli) #30424
[d277c375fd] - lib: changed var to let (Oliver Belaifa) #30427
[0fd89cc0f1] - lib: replace var with let/const (Dries Stelten) #30409
[bdba03e3ed] - lib: change var to let (Dimitris Ktistakis) #30408
[48fef42ca9] - lib: replace var with let/const (Tembrechts) #30404
[502173b54e] - lib: replace var to let in cli_table.js (Jing Lin) #30400
[2cf8a7f117] - module: fix specifier resolution algorithm (Rongjian Zhang) #30574
[be9788bf20] - n-api: detach external ArrayBuffers on env exit (Anna Henningsen) #30551
[8171cef921] - (SEMVER-MINOR) n-api: implement napi_is_detached_arraybuffer (Denys Otrishko) #30613
[cc5875b2e6] - n-api: add missed nullptr check in napi_has_own_property (Denys Otrishko) #30626
[017280e6e2] - net: replaced vars to lets and consts (nathias) #30401
[56248a827a] - process: replace var with let/const (Jesper Ek) #30382
[5c40b2f9ac] - process: replace vars in per_thread.js (EmaSuriano) #30385
[c50bbf58da] - readline: change var to let (dnlup) #30435
[b91d22cc8d] - repl: fix referrer for dynamic import (Corey Farrell) #30609
[4e5818a456] - repl: change var to let (Oliver Belaifa) #30428
[e65ad865c6] - src: change header file in node_stat_watcher.cc (Reza Fatahi) #29976
[be84ceefb8] - src: clean up node_file.h (Anna Henningsen) #30530
[bccfd124b0] - src: remove unused variable in node_dir.cc (gengjiawen) #30267
[fc11db18fe] - src: inline SetSNICallback (Anna Henningsen) #30548
[7bd587ef0c] - src: use BaseObjectPtr to store SNI context (Anna Henningsen) #30548
[8ec0d75de7] - src: cleanup unused headers (Alexandre Ferrando) #30328
[6c249c0982] - src: run native immediates during Environment cleanup (Anna Henningsen) #30666
[bea25016d1] - src: no SetImmediate from destructor in stream_pipe code (Anna Henningsen) #30666
[94357db815] - src: add more can\_call\_into\_js() guards (Anna Henningsen) #30666
[d54432f974] - src: keep object alive in stream_pipe code (Anna Henningsen) #30666
[d194c0ff37] - src: replaced var with let (Aldo Ambrosioni) #30397
[44f28ea155] - src: fix -Wsign-compare warnings (cjihrig) #30565
[1916acb3cb] - src: fix signal handler crash on close (Shelley Vohr) #30582
[9e9e48bf7e] - src: use uv_async_t for WeakRefs (Anna Henningsen) #30616
[9d8d2e1f45] - src,doc: fix broken links (cjihrig) #30662
[f135c38796] - src,doc: add C++ internals documentation (Anna Henningsen) #30552
[e968e26dbd] - stream: improve performance for sync write finishes (Anna Henningsen) #30710
[49e047f7a1] - test: add coverage for ERR_TLS_INVALID_PROTOCOL_VERSION (Rich Trott) #30741
[81d81a5904] - test: add an indicator isIBMi (Xu Meng) #30714
[37c70ee198] - test: use arrow functions in async-hooks tests (garygsc) #30137
[b5c7dad95a] - test: fix test-benchmark-streams (Rich Trott) #30757
[1e199ceb71] - test: move test-http-max-http-headers to parallel (Rich Trott) #30712
[1918b4e84f] - test: correct header length subtraction (Rich Trott) #30712
[1222be81e3] - test: remove unused callback argument (Rich Trott) #30712
[d69b9b753a] - test: simplify forEach() usage (Rich Trott) #30712
[01ab031cca] - test: remove unused callback argument (Rich Trott) #30712
[93707c4916] - test: increase coverage for trace_events.js (Rich Trott) #30705
[4800b623ed] - test: use arrow functions in addons tests (garygsc) #30131
[ba0115fe6f] - test: refactor createHook test (Jeny) #30568
[099d3fdf87] - test: port worker + buffer test to N-API (Anna Henningsen) #30551
[83861fb333] - test: revert 6d022c1 (Anna Henningsen) #30708
[a3b758d634] - test: move test-https-server-consumed-timeout to parallel (Rich Trott) #30677
[00f532f15e] - test: remove unnecessary common.platformTimeout() call (Rich Trott) #30677
[ecb902f33c] - test: do not skip test-http-server-consumed-timeout (Rich Trott) #30677
[49458deb4f] - test: remove unused function argument from http test (Rich Trott) #30677
[a2f440d326] - test: add logging in case of infinite loop (Rich Trott) #30649
[3e3ad396bd] - test: remove destructuring from test-inspector-contexts (Rich Trott) #30649
[3571e132a7] - test: check for session.post() errors in test-insepctor-context (Rich Trott) #30649
[37696320a2] - test: add mustCall() to test-inspector-contexts (Rich Trott) #30649
[0972fa3c16] - test: add regression test for signal handler removal in exit (Anna Henningsen) #30589
[5ecfd947e2] - (SEMVER-MINOR) test: update and harden http2-reset-flood (Denys Otrishko) #30534
[70d6fa122a] - test: skip test-domain-error-types in debug mode temporariliy (Rich Trott) #30629
[949f2ad528] - test: move test-worker-prof to sequential (Rich Trott) #30628
[d4b61709f1] - test: dir class initialisation w/o handler (Dmitriy Kikinskiy) #30313
[60b17b4fe6] - test: change object assign by spread operator (poutch) #30438
[97e627335f] - test: use useful message argument in test function (Rich Trott) #30618
[d651c7dd6b] - test: test for minimum ICU version consistency (Richard Lau) #30608
[dade9069c3] - test: code&learn var to let update (Nazar Malyy) #30436
[e401e8c8ed] - test: change object assign to spread object (poutch) #30422
[2ecc735c48] - test: use spread instead of Object.assign (dnlup) #30419
[d8da9dacab] - test: changed var to let in module-errors (Jamar Torres) #30413
[9dab32f340] - test: use spread instead of object.assign (Shubham Chaturvedi) #30412
[7e7a8165a8] - test: replace var with let in pre_execution.js (Vladimir Adamic) #30411
[8a9ee48797] - test: change var to let in test-trace-events (Jon Church) #30406
[d6a448825c] - test: dns utils replace var (Osmond van Hemert) #30405
[01e0571e94] - test: test cover cases when trace is empty (telenord) #30311
[f8dfa2d704] - test: switch to object spread in common/benchmark.js (palmires) #30309
[36671f9bf8] - test: add common.mustCall() to stream test (Rich Trott) #30561
[106235fe91] - test: move explanatory comment to expected location in file (Rich Trott) #30561
[081b4e2496] - test: move stream test to parallel (Rich Trott) #30561
[103d01e057] - test: remove string literal as message in strictEqual() in stream test (Rich Trott) #30561
[ebba3228e2] - test: use arrow function for callback in stream test (Rich Trott) #30561
[e122d397c0] - test: replace setTimeout with setImmediate in stream test (Rich Trott) #30561
[20ee4997f3] - test: refactor test-dgram-multicast-set-interface-lo.js (Taylor Gagne) #30536
[7aa1df7076] - tls: introduce ERR_TLS_INVALID_CONTEXT (Rich Trott) #30718
[0b0f0237c1] - tls: add memory tracking support to SSLWrap (Anna Henningsen) #30548
[89e2c71b27] - tls: allow empty subject even with altNames defined (Jason Macgowan) #22906
[941a91daed] - tools: enforce blank line between functions (Rich Trott) #30696
[5a6f836a15] - tools: add unified plugin changing links for html docs (Marek Łabuz) #29946
[84f7b5c752] - tools: enable more eslint rules (cjihrig) #30598
[5522467cf5] - tools: update ESLint to 6.7.1 (cjihrig) #30598
[1f10681496] - tty: truecolor check moved before 256 check (Duncan Healy) #30474
[6a0dd1cbbd] - util: fix .format() not always calling toString when it should be (Ruben Bridgewater) #30343
[1040e7222f] - util: fix inspection of errors with tampered name or stack property (Ruben Bridgewater) #30576
[18e9b56bf6] - util: use let instead of var for util/inspect.js (Luciano) #30399
[9ec53cf5c1] - (SEMVER-MINOR) wasi: introduce initial WASI support (cjihrig) #30258

Schedule a task on the main event loop, similar to what the HTML spec recommends for browsers. Alternative to #30198 PR-URL: #30616 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

The third parameter should be a boolean indicating whether the number must be positive. Passing zero works, but is unnecessary, misleading and inconsistent with other uses of the same function. PR-URL: #30579 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Convert functions to arrow functions. Remove unused param('signal') from function. PR-URL: #30536 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #30587 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #30582 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

Replace "X is not recommended" with "Avoid X". Replace "It is recommended not to use X" with "Avoid X". PR-URL: #30558 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Replace setTimeout() with setImmediate() in test-stream-writable-clear-buffer. The test still fails in Node.js 8.6.0 (if you comment out the `common` module, since it uses BigInts and those aren't supported in 8.6.0). PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

This reveals the values that cause the assertion error, should it happen. PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

I don't believe there's a reason test-stream-writable-clear-buffer needs to be in sequential. Move it to parallel. PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: #30561 (review) PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: https://github.com/nodejs/node/pull/30561/files#r348667256 PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

This aims to help explain some of the internal patterns and utilities that we use. It is by no means exhaustive, and suggestions for additions are welcome. Some of this is based on the existing work from #26929. Refs: #26929 PR-URL: #30552 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Refs: #29766 This works on destructuring primordials whithin libs/_http_agent PR-URL: #30416 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

PR-URL: #30315 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

This commit addresses the following compilation warnings: ../src/node_crypto.cc:5053:3: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare] CHECK_EQ(n, BN_bn2binpad(r, data, n)); ../src/node_crypto.cc:5054:3: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare] CHECK_EQ(n, BN_bn2binpad(s, data + n, n)); PR-URL: #30565 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

PR-URL: #30428 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

PR-URL: #30577 Refs: nodejs/code-and-learn#97 Refs: #29766 Refs: #29633 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

PR-URL: #30307 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #30435 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #30417 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

PR-URL: #30309 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #30400 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #30401 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

cover prepare_stack_trace in case when trace is empty PR-URL: #30311 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

PR-URL: #30402 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #30405 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #30404 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #30406 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #30407 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Notable changes: * http: * Make maximum header size configurable per-stream or per-server (Anna Henningsen) #30570 * http2: * Make maximum tolerated rejected streams configurable (Denys Otrishko) #30534 * Allow to configure maximum tolerated invalid frames (Denys Otrishko) #30534 * wasi: * Introduce initial WASI support (cjihrig) #30258 PR-URL: #30774

CI: https://ci.nodejs.org/job/node-test-pull-request/27304/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2106/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2671/

Benchmarks:
Buffers: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/475/
Streams: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/476/ (Does not yet work properly)

V8 CI has errors:

@nodejs/v8-update PTAL at the V8 failures.

I am also fine to exclude the V8 updates from the release.

Oh gosh, please no. Those V8 updates were crucial bug fixes.

It might be worth calling out #30644 in the notable changes. Even though rimraf is still experimental, it's a change in the way it operates.

Notable changes: * fs: * Reworked experimental recursive `rmdir()` (cjihrig) #30644 * The `maxBusyTries` option is renamed to `maxRetries`, and its default is set to 0. The `emfileWait` option has been removed, and `EMFILE` errors use the same retry logic as other errors. The `retryDelay` option is now supported. `ENFILE` errors are now retried. * http: * Make maximum header size configurable per-stream or per-server (Anna Henningsen) #30570 * http2: * Make maximum tolerated rejected streams configurable (Denys Otrishko) #30534 * Allow to configure maximum tolerated invalid frames (Denys Otrishko) #30534 * wasi: * Introduce initial WASI support (cjihrig) #30258 PR-URL: #30774

@targos I ran the V8 tests locally and they passed. Therefore it's difficult to identify the concrete change that might have caused the failure.

CI: https://ci.nodejs.org/job/node-test-pull-request/27306/
CITGM (v13.2.0): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2107/
Release build: https://ci-release.nodejs.org/job/iojs+release/4890/

@BridgeAR @targos All the V8 failures are from tests for experimental features, i.e. that require --harmony-... flags, so I would be okay with going forward with this even if we don’t figure out why they failed. None of the deps/v8 changes here look like they would be related, too…

Seems like the V8 failures where also present in v13.2.0 https://ci.nodejs.org/job/node-test-commit-v8-linux/2673/#showFailuresLink

CITGM is also LG compared to v13.2.0.

The ARM CI is slow, just as with the last release.

Release build: https://ci-release.nodejs.org/job/iojs+release/4890/

CI: https://ci.nodejs.org/job/node-test-pull-request/27311/

Seems like the CI can not fully finish but everything passed at least once besides the CI that is down.

nodejs/build#2074

CI: https://ci.nodejs.org/job/node-test-pull-request/27313/

PR-URL: #30774

Notable changes: * fs: * Reworked experimental recursive `rmdir()` (cjihrig) #30644 * The `maxBusyTries` option is renamed to `maxRetries`, and its default is set to 0. The `emfileWait` option has been removed, and `EMFILE` errors use the same retry logic as other errors. The `retryDelay` option is now supported. `ENFILE` errors are now retried. * http: * Make maximum header size configurable per-stream or per-server (Anna Henningsen) #30570 * http2: * Make maximum tolerated rejected streams configurable (Denys Otrishko) #30534 * Allow to configure maximum tolerated invalid frames (Denys Otrishko) #30534 * wasi: * Introduce initial WASI support (cjihrig) #30258 PR-URL: #30774

Refs: nodejs/node#30774

addaleax and others added 30 commits November 29, 2019 11:21

src: use uv_async_t for WeakRefs

9e9e48b

Schedule a task on the main event loop, similar to what the HTML spec recommends for browsers. Alternative to #30198 PR-URL: #30616 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

test: refactor test-dgram-multicast-set-interface-lo.js

20ee499

Convert functions to arrow functions. Remove unused param('signal') from function. PR-URL: #30536 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

doc: fix a typo in a date for version 13.2.0

19d192d

PR-URL: #30587 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

test: use arrow function for callback in stream test

ebba322

PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

test: remove string literal as message in strictEqual() in stream test

103d01e

This reveals the values that cause the assertion error, should it happen. PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

test: move stream test to parallel

081b4e2

I don't believe there's a reason test-stream-writable-clear-buffer needs to be in sequential. Move it to parallel. PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

test: move explanatory comment to expected location in file

106235f

Refs: #30561 (review) PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

test: add common.mustCall() to stream test

36671f9

Refs: https://github.com/nodejs/node/pull/30561/files#r348667256 PR-URL: #30561 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

repl: change var to let

4e5818a

PR-URL: #30428 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

http2: replace var with let/const

f7ca7e6

PR-URL: #30417 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

net: replaced vars to lets and consts

017280e

PR-URL: #30401 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

test: test cover cases when trace is empty

01e0571

cover prepare_stack_trace in case when trace is empty PR-URL: #30311 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

lib: replace var with let/const

48fef42

PR-URL: #30404 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

BridgeAR marked this pull request as ready for review December 3, 2019 10:44

targos approved these changes Dec 3, 2019

View reviewed changes

Comment thread doc/changelogs/CHANGELOG_V13.md Outdated

cjihrig approved these changes Dec 3, 2019

View reviewed changes

BridgeAR force-pushed the v13.3.0-proposal branch from 8906c52 to f5fe384 Compare December 3, 2019 14:28

BethGriggs approved these changes Dec 3, 2019

View reviewed changes

BridgeAR merged commit f5fe384 into v13.x Dec 3, 2019

BridgeAR added a commit that referenced this pull request Dec 3, 2019

Working on v13.3.1

355b48b

PR-URL: #30774

BridgeAR added a commit to BridgeAR/nodejs.org that referenced this pull request Dec 3, 2019

Blog: v13.3.0 release post

b5c9b87

Refs: nodejs/node#30774

BridgeAR added a commit to nodejs/nodejs.org that referenced this pull request Dec 3, 2019

Blog: v13.3.0 release post

bdd3702

Refs: nodejs/node#30774

BridgeAR mentioned this pull request Dec 3, 2019

Blog: v13.3.0 release post nodejs/nodejs.org#2812

Merged

BridgeAR added a commit to nodejs/nodejs.org that referenced this pull request Dec 3, 2019

Blog: v13.3.0 release post (#2812 )

bd35465

Refs: nodejs/node#30774

BridgeAR deleted the v13.3.0-proposal branch December 3, 2019 22:51

addaleax mentioned this pull request Jan 7, 2020

v13.6.0 proposal #31238

Merged

schmidt-sebastian mentioned this pull request Apr 17, 2020

Bandwidth exhausted error keeps showing up googleapis/nodejs-firestore#1024

Closed

v13.3.0 proposal by BridgeAR · Pull Request #30774 · nodejs/node · GitHub

Uh oh!

Uh oh!

v13.3.0 proposal - #30774

v13.3.0 proposal#30774BridgeAR merged 180 commits intov13.xnodejs/node:v13.xfrom v13.3.0-proposalnodejs/node:v13.3.0-proposalCopy head branch name to clipboard

Conversation

BridgeAR commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable Changes

Commits

Uh oh!

nodejs-github-bot commented Dec 3, 2019 • edited by BridgeAR Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

targos commented Dec 3, 2019

Uh oh!

BridgeAR commented Dec 3, 2019

Uh oh!

bricss commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented Dec 3, 2019

Uh oh!

nodejs-github-bot commented Dec 3, 2019 • edited by BridgeAR Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

addaleax commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Dec 3, 2019

Uh oh!

nodejs-github-bot commented Dec 3, 2019

Uh oh!

BridgeAR commented Dec 3, 2019

Uh oh!

nodejs-github-bot commented Dec 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v13.3.0 proposal#30774
BridgeAR merged 180 commits into
v13.xfrom
v13.3.0-proposal

BridgeAR commented Dec 3, 2019 •
edited
Loading

nodejs-github-bot commented Dec 3, 2019 •
edited by BridgeAR
Loading

bricss commented Dec 3, 2019 •
edited
Loading

nodejs-github-bot commented Dec 3, 2019 •
edited by BridgeAR
Loading

addaleax commented Dec 3, 2019 •
edited
Loading