FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: automatically manage memory for ECDSA_SIG by tniessen · Pull Request #30641 · nodejs/node · GitHub

/ node Public

crypto: automatically manage memory for ECDSA_SIG - #30641

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:crypto-use-automatic-memory-management-for-ecdsasig
ConversationCommits (1)ChecksFiles changed
Closed

crypto: automatically manage memory for ECDSA_SIG#30641
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:crypto-use-automatic-memory-management-for-ecdsasig

Conversation

tniessen commented Nov 25, 2019

Copy link
Copy Markdown
Member

As suggested by @bnoordhuis in #29292.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Nov 25, 2019

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 27, 2019

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Nov 29, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27180/

addaleax pushed a commit that referenced this pull request Nov 30, 2019
crypto: automatically manage memory for ECDSA_SIG
f6a4a36 
Refs: #29292

PR-URL: #30641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax commented Nov 30, 2019

Copy link
Copy Markdown
Member

Landed in f6a4a36

addaleax closed this Nov 30, 2019
addaleax pushed a commit that referenced this pull request Nov 30, 2019
crypto: automatically manage memory for ECDSA_SIG
4affc30 
Refs: #29292

PR-URL: #30641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
crypto: automatically manage memory for ECDSA_SIG
2e06b85 
Refs: #29292

PR-URL: #30641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request Jan 15, 2020
Closed
tniessen deleted the crypto-use-automatic-memory-management-for-ecdsasig branch January 23, 2020 03:48
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
crypto: automatically manage memory for ECDSA_SIG
dd118b7 
Refs: #29292

PR-URL: #30641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
tniessen removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL