http2: change var to let compact.js - #30392
Closed
MariaEmma wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cjihrig
approved these changes
Nov 12, 2019
addaleax
approved these changes
Nov 12, 2019
jasnell
approved these changes
Nov 12, 2019
trivikr
approved these changes
Nov 13, 2019
trivikr
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with some nits
Sorry, something went wrong.
Comment thread
lib/internal/http2/compat.js
| headers = statusMessage; | ||
|
|
||
| var i; | ||
| let i; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nit: move to inside for loop on lines 611 and 618?
for (let i = 0; i < headers.length; i++) {for (let i = 0; i < keys.length; i++) {
Sorry, something went wrong.
BridgeAR
approved these changes
Nov 13, 2019
gireeshpunathil
approved these changes
Nov 14, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
the only failure in linux-containerized run node-api/test_make_callback/test-async-hooks-gcable is known as in #30648 |
Sorry, something went wrong.
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 26, 2019
PR-URL: #30392 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Copy link
Copy Markdown
Member
|
landed in dba276d. thanks for the contribution! |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30392 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30392 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30392 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change var to let in http2/compact.js
Checklist