Replace Number to Primordials - #30700
Closed
Sebastien-Ahkrin wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Sebastien-Ahkrin
force-pushed
the
Number-enforce
branch
from
2935122 to
3ad8e2f
Compare
November 28, 2019 13:21
targos
reviewed
Nov 28, 2019
Comment thread
lib/internal/http2/util.js
Outdated
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
approved these changes
Nov 28, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cjihrig
approved these changes
Nov 28, 2019
trivikr
approved these changes
Nov 28, 2019
targos
force-pushed
the
Number-enforce
branch
from
48040d6 to
979ed18
Compare
November 30, 2019 12:52
targos
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30700 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This comment has been minimized.
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30700 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30700 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30700 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update some file to replace Number to the primordial Number.
And i just have created a line in "/lib/.eslintrc.yaml".
And replace every code :
By
in theses files :
This task was given to me by @targos thanks ❤️
I hope this PR will help you :x