lib: use static Number properties from primordials - #30686
Closed
targos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
trivikr
approved these changes
Nov 27, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
force-pushed
the
primordials-number
branch
from
d24381c to
b99dbd0
Compare
November 30, 2019 12:26
Copy link
Copy Markdown
Member
Author
|
@addaleax would you like to review? |
Sorry, something went wrong.
addaleax
approved these changes
Nov 30, 2019
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Code looks good
Sorry, something went wrong.
targos
force-pushed
the
primordials-number
branch
from
b99dbd0 to
41bdd02
Compare
November 30, 2019 12:45
targos
added a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30686 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
added a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30686 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
targos
added a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30686 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30686 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist