test: test cover prepare_stack_trace in case of trace is empty - #30311
Closed
telenord wants to merge 3 commits into
Closed
test: test cover prepare_stack_trace in case of trace is empty#30311telenord wants to merge 3 commits into
telenord wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
ChALkeR
reviewed
Nov 6, 2019
Comment thread
test/fixtures/source-map/emptyStackError.js
Outdated
gireeshpunathil
approved these changes
Nov 21, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@telenord The email used for the commit is not registered with GitHub. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 24, 2019
cover prepare_stack_trace in case when trace is empty PR-URL: #30311 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Copy link
Copy Markdown
Member
|
landed in d90219d, thanks for the contribution! |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
cover prepare_stack_trace in case when trace is empty PR-URL: #30311 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
cover prepare_stack_trace in case when trace is empty PR-URL: #30311 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
cover prepare_stack_trace in case when trace is empty PR-URL: #30311 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist