FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: make maximum header size configurable per-stream or per-server by addaleax · Pull Request #30570 · nodejs/node · GitHub

/ node Public

http: make maximum header size configurable per-stream or per-server - #30570

Closed
addaleax wants to merge 4 commits into
nodejs:masterfrom
addaleax:http-max-header-size-configurable
ConversationCommits (4)ChecksFiles changed
Closed

http: make maximum header size configurable per-stream or per-server#30570
addaleax wants to merge 4 commits into
nodejs:masterfrom
addaleax:http-max-header-size-configurable

Conversation

addaleax commented Nov 20, 2019

Copy link
Copy Markdown
Member

Make maxHeaderSize a.k.a. --max-header-size configurable now that
the legacy parser is gone (which only supported a single global value).

Refs: #30567

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

addaleax added http Issues or PRs related to the http subsystem. semver-minor PRs that contain new features and should be released in the next minor version. labels Nov 20, 2019
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 20, 2019
addaleax mentioned this pull request Nov 20, 2019
Closed
4 tasks
mcollina approved these changes Nov 21, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

(this is also backportable to Node 12 with a bit of work).

addaleax commented Nov 21, 2019

Copy link
Copy Markdown
Member Author

(this is also backportable to Node 12 with a bit of work).

@mcollina Are you having something in mind that’s only enabled when not using --http-parser=legacy?

mcollina commented Nov 21, 2019

Copy link
Copy Markdown
Member

Exactly.

cjihrig approved these changes Nov 21, 2019
View reviewed changes
Comment thread doc/api/http.md Outdated
Comment thread doc/api/http.md Outdated
Comment thread lib/_http_client.js Outdated
Comment thread lib/_http_server.js Outdated
sam-github approved these changes Nov 21, 2019
View reviewed changes

sam-github left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, modulo a doc nit. Might be interesting to test tiny values, like 12 (itended to be 12 K, but not actually). Maybe there should be a minimum of 500 or something? <-- just a suggestion/question, not even a nit.

Comment thread doc/api/http.md Outdated

addaleax commented Nov 22, 2019

Copy link
Copy Markdown
Member Author

@cjihrig @sam-github Nits should be addressed now

Might be interesting to test tiny values, like 12 (itended to be 12 K, but not actually). Maybe there should be a minimum of 500 or something? <-- just a suggestion/question, not even a nit.

I’d figure somebody would notice pretty quickly if they set overly small values, but if a user is sure that that is what they want, I don’t think we need to stop them.

nodejs-github-bot commented Nov 22, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26849/

sam-github commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

I’d figure somebody would notice pretty quickly if they set overly small values

I'd be curious if setting a max size of 1 or 5 (bytes) will cause node to segv or abort() because its so unexpected, but that's unrelated to this PR, and I take your point about not bothering to protect people from non-functionally small valuea. If you ask for broken, you get broken.

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 29, 2019

nodejs-github-bot commented Nov 29, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27172/

nodejs-github-bot commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27186/

lundibundi approved these changes Nov 30, 2019
View reviewed changes

lundibundi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

Comment thread lib/_http_client.js Outdated
Comment thread src/node_options.cc Outdated
Comment thread test/parallel/test-http-max-header-size-per-stream.js
http: make maximum header size configurable per-stream or per-server
abc91f4 
Make `maxHeaderSize` a.k.a. `--max-header-size` configurable now that
the legacy parser is gone (which only supported a single global value).

Refs: nodejs#30567
fixup! http: make maximum header size configurable per-stream or per-…
a92936a 
…server
fixup! http: make maximum header size configurable per-stream or per-…
65d8813 
…server
addaleax force-pushed the http-max-header-size-configurable branch from cc20b41 to 65d8813 Compare November 30, 2019 14:49

nodejs-github-bot commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27210/

nodejs-github-bot commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27215/

nodejs-github-bot commented Dec 1, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27237/

addaleax commented Dec 1, 2019

Copy link
Copy Markdown
Member Author

Landed in 6bf5a1d

addaleax closed this Dec 1, 2019
addaleax deleted the http-max-header-size-configurable branch December 1, 2019 02:01
addaleax added a commit that referenced this pull request Dec 1, 2019
http: make maximum header size configurable per-stream or per-server
6bf5a1d 
Make `maxHeaderSize` a.k.a. `--max-header-size` configurable now that
the legacy parser is gone (which only supported a single global value).

Refs: #30567

PR-URL: #30570
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
http: make maximum header size configurable per-stream or per-server
6257408 
Make `maxHeaderSize` a.k.a. `--max-header-size` configurable now that
the legacy parser is gone (which only supported a single global value).

Refs: #30567

PR-URL: #30570
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
BridgeAR mentioned this pull request Dec 3, 2019
Merged
BridgeAR added a commit that referenced this pull request Dec 3, 2019
2019-12-03, Version 13.3.0 (Current)
8906c52 
Notable changes:

* http:
  * Make maximum header size configurable per-stream or per-server
    (Anna Henningsen) #30570
* http2:
  * Make maximum tolerated rejected streams configurable (Denys
    Otrishko) #30534
  * Allow to configure maximum tolerated invalid frames (Denys
    Otrishko) #30534
* wasi:
  * Introduce initial WASI support (cjihrig)
    #30258

PR-URL: #30774
BridgeAR added a commit that referenced this pull request Dec 3, 2019
2019-12-03, Version 13.3.0 (Current)
f5fe384 
Notable changes:

* fs:
  * Reworked experimental recursive `rmdir()`  (cjihrig)
    #30644
    * The `maxBusyTries` option is renamed to `maxRetries`, and its
      default is set to 0. The `emfileWait` option has been removed,
      and `EMFILE` errors use the same retry logic as other errors.
      The `retryDelay` option is now supported. `ENFILE` errors are
      now retried.
* http:
  * Make maximum header size configurable per-stream or per-server
    (Anna Henningsen) #30570
* http2:
  * Make maximum tolerated rejected streams configurable (Denys
    Otrishko) #30534
  * Allow to configure maximum tolerated invalid frames (Denys
    Otrishko) #30534
* wasi:
  * Introduce initial WASI support (cjihrig)
    #30258

PR-URL: #30774
BridgeAR added a commit that referenced this pull request Dec 3, 2019
2019-12-03, Version 13.3.0 (Current)
4091ea9 
Notable changes:

* fs:
  * Reworked experimental recursive `rmdir()`  (cjihrig)
    #30644
    * The `maxBusyTries` option is renamed to `maxRetries`, and its
      default is set to 0. The `emfileWait` option has been removed,
      and `EMFILE` errors use the same retry logic as other errors.
      The `retryDelay` option is now supported. `ENFILE` errors are
      now retried.
* http:
  * Make maximum header size configurable per-stream or per-server
    (Anna Henningsen) #30570
* http2:
  * Make maximum tolerated rejected streams configurable (Denys
    Otrishko) #30534
  * Allow to configure maximum tolerated invalid frames (Denys
    Otrishko) #30534
* wasi:
  * Introduce initial WASI support (cjihrig)
    #30258

PR-URL: #30774
maxharlow mentioned this pull request Jan 13, 2020
Closed
addaleax mentioned this pull request Jan 24, 2020
Closed
4 tasks
joyeecheung mentioned this pull request Jun 8, 2020
Closed
3 tasks
richardlau mentioned this pull request Jun 10, 2021
Closed
Ayase-252 mentioned this pull request Jun 10, 2021
Closed
nodejs-github-bot pushed a commit that referenced this pull request Jun 26, 2021
http,https: align server option of https with http
8a8c7f4 
Fixes: #38954

PR-URL: #38992
Refs: #30570
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2021
http,https: align server option of https with http
35331cb 
Fixes: #38954

PR-URL: #38992
Refs: #30570
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+3 more reviewers
sam-github sam-github approved these changes
devnexen devnexen approved these changes
lundibundi lundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http Issues or PRs related to the http subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL