FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib/internal: Use let instead of var for util.js and process/warning.js by 19shubham11 · Pull Request #30375 · nodejs/node · GitHub

/ node Public

lib/internal: Use let instead of var for util.js and process/warning.js - #30375

Closed
19shubham11 wants to merge 1 commit into
nodejs:masterfrom
19shubham11:use_let_instead_of_var
ConversationCommits (1)ChecksFiles changed
Closed

lib/internal: Use let instead of var for util.js and process/warning.js#30375
19shubham11 wants to merge 1 commit into
nodejs:masterfrom
19shubham11:use_let_instead_of_var

Conversation

19shubham11 commented Nov 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added process Issues and PRs related to the process subsystem. util Issues and PRs related to the built-in util module. labels Nov 12, 2019
19shubham11 changed the title lib/internal: this commit uses let instead of var for util.js and process/warning.js lib/internal: Use let instead of var for util.js and process/warning.js Nov 12, 2019
19shubham11 force-pushed the use_let_instead_of_var branch from 3471857 to 0409a75 Compare November 12, 2019 15:14
jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 13, 2019

BridgeAR commented Nov 13, 2019

Copy link
Copy Markdown
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4071/

nodejs-github-bot commented Nov 14, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26584/

nodejs-github-bot commented Nov 16, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26602/

nodejs-github-bot commented Nov 17, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26662/

nodejs-github-bot commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27029/

gireeshpunathil commented Nov 26, 2019

Copy link
Copy Markdown
Member

the windows failure parallel/test-inspector-wait-for-connection is known as in #30619

the windows failure sequential/test-inspector-contexts is known as in #30519

the linux-containerized failure parallel/test-domain-error-types is known as in #30498

the failure in linux-containerized run node-api/test_make_callback/test-async-hooks-gcable is known as in #30648

gireeshpunathil pushed a commit that referenced this pull request Nov 26, 2019
lib: use let instead of var
a2dfa3c 
this commit uses let instead of var for util.js & warning.js
PR-URL: #30375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

gireeshpunathil commented Nov 26, 2019

Copy link
Copy Markdown
Member

landed in a2dfa3c

19shubham11 deleted the use_let_instead_of_var branch November 26, 2019 14:33
addaleax pushed a commit that referenced this pull request Nov 30, 2019
lib: use let instead of var
b545b91 
this commit uses let instead of var for util.js & warning.js
PR-URL: #30375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
lib: use let instead of var
363391e 
this commit uses let instead of var for util.js & warning.js
PR-URL: #30375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR mentioned this pull request Dec 3, 2019
Merged
BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
lib: use let instead of var
d138e2d 
this commit uses let instead of var for util.js & warning.js
PR-URL: #30375
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs mentioned this pull request Dec 23, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
BethGriggs BethGriggs approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. process Issues and PRs related to the process subsystem. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL