FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed a typo in a date for version 13.2.0 by kirlat · Pull Request #30587 · nodejs/node · GitHub

/ node Public

Fixed a typo in a date for version 13.2.0 - #30587

Closed
kirlat wants to merge 2 commits into
nodejs:masterfrom
kirlat:changelog-fix
ConversationCommits (2)ChecksFiles changed
Closed

Fixed a typo in a date for version 13.2.0#30587
kirlat wants to merge 2 commits into
nodejs:masterfrom
kirlat:changelog-fix

Conversation

kirlat commented Nov 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Checklist

Fixed a typo in a date for version 13.2.0. See #30585

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 22, 2019
targos reviewed Nov 22, 2019
View reviewed changes
Comment thread doc/changelogs/CHANGELOG_V13.md Outdated

<a id="13.2.0"></a>
## 2019-21-19, Version 13.2.0 (Current), @MylesBorins
## 2019-11-21git log --oneline files/you/changed, Version 13.2.0 (Current), @MylesBorins

targos Nov 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
## 2019-11-21git log --oneline files/you/changed, Version 13.2.0 (Current), @MylesBorins
## 2019-11-21, Version 13.2.0 (Current), @MylesBorins

😉

kirlat Nov 22, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, will fix, Bad with texts too 🙂

targos approved these changes Nov 22, 2019
View reviewed changes

targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thanks!

targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 22, 2019

targos commented Nov 22, 2019

Copy link
Copy Markdown
Member

collaborators: 👍 to fast-track

kirlat commented Nov 22, 2019

Copy link
Copy Markdown
Author

I see that a check fails because it does not see subsystem in the commit message. I've checked other commit messages for this file and they do not have subsystem too. Don't know if I need to do anything about it or not (never committed to node.js before 🙂)

targos commented Nov 22, 2019

Copy link
Copy Markdown
Member

doc is fine as a subsystem. I suggest doc: fix a typo in a date for version 13.2.0

addaleax commented Nov 22, 2019

Copy link
Copy Markdown
Member

Landed in f6de66e, thanks for the PR!

addaleax closed this Nov 22, 2019
addaleax pushed a commit that referenced this pull request Nov 22, 2019
doc: fix a typo in a date for version 13.2.0
f6de66e 
PR-URL: #30587
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 mentioned this pull request Nov 22, 2019
Closed
4 tasks
addaleax pushed a commit that referenced this pull request Nov 30, 2019
doc: fix a typo in a date for version 13.2.0
19d192d 
PR-URL: #30587
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR mentioned this pull request Dec 3, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
gireeshpunathil gireeshpunathil approved these changes
BethGriggs BethGriggs approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL